Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: 🎨 Enh/api server error handling #5233

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

pcrespov
Copy link
Member

What do these changes do?

api server error handling

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@pcrespov pcrespov added the a:apiserver api-server service label Jan 12, 2024
@pcrespov pcrespov self-assigned this Jan 12, 2024
@pcrespov pcrespov changed the title 🎨 Enh/api server error handling WIP: 🎨 Enh/api server error handling Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3693767) 87.2% compared to head (f878d06) 65.0%.

❗ Current head f878d06 differs from pull request most recent head 68e520f. Consider uploading reports for the commit 68e520f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5233      +/-   ##
=========================================
- Coverage    87.2%   65.0%   -22.3%     
=========================================
  Files        1307     535     -772     
  Lines       53522   26935   -26587     
  Branches     1170     202     -968     
=========================================
- Hits        46724   17519   -29205     
- Misses       6549    9366    +2817     
+ Partials      249      50     -199     
Flag Coverage Δ
integrationtests 65.0% <ø> (-0.1%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1098 files with indirect coverage changes

@pcrespov pcrespov force-pushed the enh/api-server-error-handling branch from f878d06 to 68e520f Compare January 28, 2024 16:02
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pcrespov pcrespov modified the milestone: Schoggilebe Feb 19, 2024
@pcrespov pcrespov added this to the Schoggilebe milestone Mar 13, 2024
@sanderegg sanderegg removed this from the Schoggilebe milestone Apr 12, 2024
@pcrespov pcrespov added this to the Enchanted Odyssey milestone Apr 12, 2024
@pcrespov pcrespov modified the milestones: South Island Iced Tea, Tom Bombadil Jul 11, 2024
@sanderegg sanderegg modified the milestones: Tom Bombadil, Eisbock Aug 13, 2024
@pcrespov pcrespov modified the milestones: Eisbock, MartinKippenberger Sep 18, 2024
@pcrespov pcrespov removed this from the MartinKippenberger milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants