Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: 🎨 Enh/payment adjustments #5125

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Dec 4, 2023

What do these changes do?

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@pcrespov pcrespov self-assigned this Dec 4, 2023
@pcrespov pcrespov added the a:payments payments service label Dec 4, 2023
@pcrespov pcrespov added this to the Kobayashi Maru milestone Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc33561) 85.4% compared to head (a7e3bdb) 60.8%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5125      +/-   ##
=========================================
- Coverage    85.4%   60.8%   -24.7%     
=========================================
  Files        1316     332     -984     
  Lines       53813   15866   -37947     
  Branches     1170       0    -1170     
=========================================
- Hits        46007    9652   -36355     
+ Misses       7557    6214    -1343     
+ Partials      249       0     -249     
Flag Coverage Δ
integrationtests 60.8% <ø> (-4.4%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1194 files with indirect coverage changes

@pcrespov pcrespov force-pushed the enh/payment-adjustments branch 7 times, most recently from cf03b93 to f59be6e Compare December 11, 2023 15:14
@pcrespov pcrespov force-pushed the enh/payment-adjustments branch 4 times, most recently from 03ff226 to a55e85b Compare December 12, 2023 13:47
Copy link

codeclimate bot commented Dec 12, 2023

Code Climate has analyzed commit a55e85b and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov force-pushed the enh/payment-adjustments branch from a55e85b to 5983c37 Compare January 4, 2024 19:25
@pcrespov pcrespov modified the milestones: Kobayashi Maru, This is Sparta! Jan 13, 2024
@pcrespov pcrespov force-pushed the enh/payment-adjustments branch from 5983c37 to 7516581 Compare January 30, 2024 08:19
@pcrespov pcrespov force-pushed the enh/payment-adjustments branch from 7516581 to a7e3bdb Compare January 30, 2024 18:41
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pcrespov pcrespov modified the milestones: This is Sparta!, Schoggilebe Feb 12, 2024
@pcrespov pcrespov added this to the Schoggilebe milestone Mar 13, 2024
@sanderegg sanderegg removed this from the Schoggilebe milestone Apr 12, 2024
@pcrespov pcrespov added this to the Enchanted Odyssey milestone Apr 12, 2024
@pcrespov pcrespov modified the milestones: South Island Iced Tea, Tom Bombadil Jul 11, 2024
@sanderegg sanderegg modified the milestones: Tom Bombadil, Eisbock Aug 13, 2024
@pcrespov pcrespov modified the milestones: Eisbock, MartinKippenberger Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:payments payments service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants