Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade openapi generator #202

Open
wants to merge 57 commits into
base: master
Choose a base branch
from

Conversation

bisgaard-itis
Copy link
Collaborator

@bisgaard-itis bisgaard-itis commented Oct 25, 2024

What do these changes do?

Related issue/s

How to test

For internal developers

@bisgaard-itis bisgaard-itis self-assigned this Oct 25, 2024
@bisgaard-itis bisgaard-itis added the dependencies Pull requests that update a dependency file label Oct 25, 2024
@bisgaard-itis bisgaard-itis added this to the MartinKippenberger milestone Oct 25, 2024
@bisgaard-itis bisgaard-itis marked this pull request as ready for review October 25, 2024 13:28
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! 🎉 ! Thx so much!

scripts/common.Makefile Outdated Show resolved Hide resolved
@pcrespov
Copy link
Member

Can you please also add a test to make sure that the new client does not have the bug in
ITISFoundation/osparc-simcore#6556? Then you can also close #192

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
thx!

clients/python/test/test_osparc/conftest.py Show resolved Hide resolved
clients/python/test/test_osparc/test_basic.py Show resolved Hide resolved
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade openapi generator cli API-server: returned values when setting metadata are wrong
4 participants