9933 configbaker expose bootstrap #9935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poikilotherm
added
the
Component: Containers
pdurbin
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Works great. Low risk. This is how I tested it:
$ touch envfile.txt
$ vim docker-compose-dev.yml
$ git diff docker-compose-dev.yml
diff --git a/docker-compose-dev.yml b/docker-compose-dev.yml
index ab44dbc180..4a0d40917e 100644
--- a/docker-compose-dev.yml
+++ b/docker-compose-dev.yml
@@ -40,7 +40,11 @@ services:
restart: "no"
command:
- bootstrap.sh
+ - -e
+ - envfile.txt
- dev
+ volumes:
+ - ./envfile.txt:/envfile.txt
networks:
- dataverse
$ cat envfile.txt
API_TOKEN=97cad752-983a-446f-866e-b032998ee33d
Approved. Just a container thing.
|
@poikilotherm There is a branch conflict, can you resolve? |
Done @kcondon |
|
Can confirm! dev_bootstrap:
container_name: "dev_bootstrap"
image: gdcc/configbaker:unstable
restart: "no"
command:
- bootstrap.sh
- -e
- env_file.txt
- dev
networks:
- dataverse
volumes:
- ./env_file.txt:/env_file.txt# env_file.txt
API_TOKEN=435c7b36-6c88-4747-9ae5-27d0bb06562d |
JR-1991
approved these changes
Sep 20, 2023
|
@JR-1991 with his next-level YAML colorization! So fancy! 🪄 🦄 🌷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add capability to expose data from within the bootstrap process
Which issue(s) this PR closes:
Special notes for your reviewer:
None
Suggestions on how to test this:
Modify compose file to mount an existing file into the bootstrap container, add
-e <file>(note the array notation!!!) and see it populated when bootstrap is runningDoes this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope
Is there a release notes update needed for this change?:
Nope
Additional documentation:
None