IQSS · tcoupin · Oct 3, 2022 · May 2, 2024 · May 14, 2024 · May 14, 2024
diff --git a/doc/release-notes/8739-publisher-during-harvesting.md b/doc/release-notes/8739-publisher-during-harvesting.md
@@ -0,0 +1 @@
+The publisher value of harvested datasets is now attributed to the dataset's distributor instead of its producer. This change affects all newly harvested datasets. For more information, see #8739
diff --git a/doc/sphinx-guides/source/admin/harvestclients.rst b/doc/sphinx-guides/source/admin/harvestclients.rst
@@ -47,3 +47,8 @@ What if a Run Fails?
 Each harvesting client run logs a separate file per run to the app server's default logging directory (``/usr/local/payara6/glassfish/domains/domain1/logs/`` unless you've changed it). Look for filenames in the format  ``harvest_TARGET_YYYY_MM_DD_timestamp.log`` to get a better idea of what's going wrong.
 
 Note that you'll want to run a minimum of Dataverse Software 4.6, optimally 4.18 or beyond, for the best OAI-PMH interoperability.
+
+Harvesting Client Changelog
+---------------------------
+
+- As of Dataverse 6.3, the publisher value of harvested datasets is now attributed to the dataset's distributor instead of its producer. This change affects all newly harvested datasets. For more information, see https://github.com/IQSS/dataverse/pull/9013
diff --git a/src/main/resources/db/migration/V6.2.0.2__8739-publisher-during-harvesting.sql b/src/main/resources/db/migration/V6.2.0.2__8739-publisher-during-harvesting.sql
@@ -0,0 +1 @@
+update foreignmetadatafieldmapping set datasetfieldname = 'distributorName' where foreignfieldxpath = ':publisher';
diff --git a/src/test/java/edu/harvard/iq/dataverse/api/HarvestingClientsIT.java b/src/test/java/edu/harvard/iq/dataverse/api/HarvestingClientsIT.java
@@ -299,6 +299,11 @@ private void harvestingClientRun(boolean allowHarvestingMissingCVV)  throws Inte
         }
         // verify count after collecting global ids
         assertEquals(expectedNumberOfSetsHarvested, jsonPath.getInt("data.total_count"));
+
+        // ensure the publisher name is present in the harvested dataset citation
+        Response harvestedDataverse = given().get(ARCHIVE_URL + "/api/dataverses/1");  
+        String harvestedDataverseName = harvestedDataverse.getBody().jsonPath().getString("data.name");        
+        assertTrue(jsonPath.getString("data.items[0].citation").contains(harvestedDataverseName));
 
         // Fail if it hasn't completed in maxWait seconds
         assertTrue(i < maxWait);
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		The publisher value of harvested datasets is now attributed to the dataset's distributor instead of its producer. This change affects all newly harvested datasets. For more information, see #8739
plecor marked this conversation as resolved. Show resolved Hide resolved
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		update foreignmetadatafieldmapping set datasetfieldname = 'distributorName' where foreignfieldxpath = ':publisher';
Copy link Member pdurbin Nov 25, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. What about datasets that are already harvested? The docs say, "This change affects all newly harvested datasets." The plan is to have a mix? Or should we add to the release note that all datasets should be re-harvested? Is that crazy? Copy link Contributor plecor Dec 3, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Indeed, the fix isn't retroactive, unless all datasets are re-harvested. This is not great but I have no idea how we could do this another way. Maybe we could only suggest re-harvesting only if people are affected by/care about the discrepancy it fixes? Copy link Member pdurbin Dec 3, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. @plecor for now, can you please add something to the release note. "All datasets should be re-harvested to pick up this change." Or whatever makes sense to you. Thanks. Copy link Contributor plecor Dec 4, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Ok. To reflect this, the full text of the release note is now: The publisher value of harvested datasets is now attributed to the dataset's distributor instead of its producer. This improves the citation associated with these datasets, but the change only affects newly harvested datasets. All datasets should be re-harvested if you wish to pick up this change on already harvested datasets. For more information, see the guides, #8739, and #9013.