bump jquery to 3.5.1 to fix sphinx search #7232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheppler
reviewed
Aug 26, 2020
| @@ -225,7 +225,7 @@ | |||
| html_static_path = ['_static'] | |||
|
|
|||
| html_js_files = [ | |||
| 'js/jquery-3.4.1.min.js', | |||
| 'js/jquery-3.5.1.min.js', | |||
There was a problem hiding this comment.
Unfortunately this is not how jQuery is updated. I thought adding a physical file would work back in #4219, but apparently that just added a second jQuery library, instead of replacing the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: this, along with updating sphinx to 3.2.1 on gdcc-jenkins01, seems to fix guide search
Which issue(s) this PR closes:
Closes #7228
Special notes for your reviewer: none
Suggestions on how to test this: testable in jenkins workspace or branch space on guides.dataverse
Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?: no
Additional documentation: none