contenttype can be null because dataset tools do not require it #6459 #6460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbrooke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This issue is currently blocked:
The reason is that I forgot to add a SQL migration in pull request #6059 to drop the non null constraint.
Which issue(s) this PR closes:
Closes #6459
Special notes for your reviewer:
None.
Suggestions on how to test this:
Does this PR introduce a user interface change?:
No.
Is there a release notes update needed for this change?:
At standup today we decided we'd wait until this pull request to decide where to put the note. I'm thinking we put the note in both the release notes for 4.17 (when pull request #6059 was merged) and the next release (when the flyway script will run). Happy to discuss.
Additional documentation:
None.