API for creating OAI-PMH sets

[pameyer]

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

• connects to API for creating OAI-PMH sets is "TODO" #4095 : API for creating OAI-PMH sets

Pull Request Checklist

• Unit tests completed
• Integration tests: None
• Deployment requirements, SQL updates, Solr updates, etc.: None
• Documentation completed
• Merged latest from "develop" branch and resolved conflicts

[coveralls]

Coverage decreased (-0.04%) to 12.915% when pulling f514d1a on exp-oai_create_api into 6dd1fcb on develop.

[landreev]

I feel like the check for set-name-already-in-used is needed. Would be just a matter of copy-and-pasting the 4 or so lines of code from HarvestingSetsPage.java. I can do that (but I understand this issue is lower priority at this point). I would also like to correct the word "definition" that is spelled as defination in a couple of places. (the parser expects it to be like that in the JSON too)

[pdurbin]

@pameyer any thoughts on this pull request? It has merge conflicts now. I agree with what you said at #4095 that "if it works from the UI, it should work from the API". That's what #3440 is all about.

[pameyer]

@pdurbin my thinking on this one hasn't changed; but it's not at the top of the priority list at the moment.

[pdurbin]

@pameyer ok. Thanks. I just hate it when pull requests are lying around open with no communication on them. I did update #3440 to say that creating OAI sets is a GUI-only feature. Bummer. 😞

[pameyer]

I think this one may be ready for another look. @sekmiller addressed what looks to me like all of @landreev's requests; and I added a few tests.

[landreev]

I was going to suggest that we try to send the set definition query to the search engine, and check if it results in any hits... similarly to what we are doing in the GUI... But eventually decided it's not needed in the API. So, approving and moving along.