Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQSS/11095- Account for multivalue needed by cvoc scripts #11096

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Dec 12, 2024

What this PR does / why we need it: This PR changes the /api/admin/index/solr/schema output to correctly indicate that a field should be multivalued when it is the term-uri field of an external controlled vocabulary config. (Note the format of the output/etc. is not changed, just the content - same as if a metadatablock were editing to make a field multivalued.)

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this: Configure the ORCID script on the depositor field as described in the issue, test that indexing doesn't work now, works after the update and updating the solr schema/restarting solr.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

@coveralls
Copy link

coveralls commented Dec 12, 2024

Coverage Status

coverage: 22.691% (+0.1%) from 22.571%
when pulling 968dfda on QualitativeDataRepository:IQSS/11095-fix-extcvoc-indexing
into a4d0127 on IQSS:develop.

@ofahimIQSS ofahimIQSS added the Size: 3 A percentage of a sprint. 2.1 hours. label Dec 17, 2024
@cmbz cmbz added the FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) label Dec 17, 2024
@pdurbin pdurbin self-assigned this Dec 19, 2024
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run the code but I assume this is a no-op if a developer were to recreate the schema.xml file using the process I'm suggesting developers follow in this pull request (please take a look):

That is, it's a no-op because we don't ship any sort of cvoc config out of the box. It's a feature that installations opt-in to.

I'm almost ready to send this to QA (test are passing: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11096/1/testReport/ ) but I did leave a few tiny suggestions.

doc/release-notes/11095-fix-extcvoc-indexing.md Outdated Show resolved Hide resolved
doc/sphinx-guides/source/admin/metadatacustomization.rst Outdated Show resolved Hide resolved
doc/sphinx-guides/source/installation/config.rst Outdated Show resolved Hide resolved
src/main/java/edu/harvard/iq/dataverse/api/Index.java Outdated Show resolved Hide resolved
@qqmyers
Copy link
Member Author

qqmyers commented Dec 19, 2024

Yes it's a no-op, but if Dataverse ever does ship with some external cvoc scripts registered, the right thing to do would be to run update-fields.sh on an instance with those scripts configured - so consistent with #11024.

@qqmyers qqmyers removed their assignment Dec 19, 2024
@pdurbin pdurbin removed their assignment Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: Ready for QA ⏩
Development

Successfully merging this pull request may close these issues.

External CVoc - indexing can fail for single valued fields
5 participants