Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include total_count_per_object_type in search response #11082

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

stevenwinship
Copy link
Contributor

What this PR does / why we need it: SPA Collection Page needs to show counts of the files, datasets, and collections (dataverses) in the results

Which issue(s) this PR closes:#11065

Special notes for your reviewer:

Suggestions on how to test this: See SearchIT

Does this PR introduce a user interface change? If mockups are available, please link/include them here: No

Is there a release notes update needed for this change?: Included

Additional documentation:

@stevenwinship stevenwinship self-assigned this Dec 10, 2024
@stevenwinship stevenwinship added Type: Feature a feature request Size: 10 A percentage of a sprint. 7 hours. SPA These changes are required for the Dataverse SPA GREI Re-arch Issues related to the GREI Dataverse rearchitecture SPA.Q4.1 Collection Page: All Filtering Options FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) labels Dec 10, 2024
@coveralls
Copy link

coveralls commented Dec 10, 2024

Coverage Status

coverage: 22.571%. remained the same
when pulling b74eb1a on 11065-extend-search-api-to-include-type-counts
into e3b5795 on develop.

This comment has been minimized.

This comment has been minimized.

3 similar comments

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Dec 11, 2024
@g-saracca
Copy link
Contributor

Hi @stevenwinship , the count returned should be on the total number of items found but not on the basis of what is returned according to the pagination, is it implemented like that?
Screen Shot 2024-12-12 at 12 19 07

@stevenwinship stevenwinship self-assigned this Dec 13, 2024
@stevenwinship
Copy link
Contributor Author

stevenwinship commented Dec 13, 2024

Fixed counts to be all results and not just a pages worth

"count_in_response": 10, "total_count_per_object_type": { "Files": 20, "Datasets": 17, "Dataverses": 15 }

@stevenwinship stevenwinship removed their assignment Dec 13, 2024

This comment has been minimized.

1 similar comment

This comment has been minimized.

Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11065-extend-search-api-to-include-type-counts
ghcr.io/gdcc/configbaker:11065-extend-search-api-to-include-type-counts

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@sekmiller sekmiller self-assigned this Dec 17, 2024
@sekmiller sekmiller removed their assignment Dec 17, 2024
@ofahimIQSS ofahimIQSS self-assigned this Dec 19, 2024
@ofahimIQSS
Copy link
Contributor

test passing - merging pr

@ofahimIQSS ofahimIQSS merged commit bee3cdf into develop Dec 19, 2024
20 checks passed
@ofahimIQSS ofahimIQSS removed their assignment Dec 19, 2024
@pdurbin pdurbin added this to the 6.6 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Size: 10 A percentage of a sprint. 7 hours. SPA.Q4.1 Collection Page: All Filtering Options SPA These changes are required for the Dataverse SPA Type: Feature a feature request
Projects
Status: Merged 🚀
Development

Successfully merging this pull request may close these issues.

Feature Request: Extend Search API to include counts for file, dataset, collection
6 participants