Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.5 release notes #11067

Merged
merged 35 commits into from
Dec 11, 2024
Merged

6.5 release notes #11067

merged 35 commits into from
Dec 11, 2024

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Dec 5, 2024

What this PR does / why we need it:

Release notes, as usual. Preview at https://github.com/IQSS/dataverse/blob/10952-release-notes/doc/release-notes/6.5-release-notes.md

Which issue(s) this PR closes:

Special notes for your reviewer:

I'll leave some comments inline.

Suggestions on how to test this:

Go through the upgrade steps on demo. Here's the issue for that:

@pdurbin pdurbin added this to the 6.5 milestone Dec 5, 2024
@pdurbin pdurbin added Size: 10 A percentage of a sprint. 7 hours. FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) labels Dec 5, 2024
- UX improvements, especially Preview URLs
- increased harvesting flexibility
- performance gains
- a security vulnerability addressed
Copy link
Member Author

@pdurbin pdurbin Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we ever put out a security announcement. We probably should. See https://guides.dataverse.org/en/6.4/developers/security.html#sending-security-notices

This is the bug that was fixed: https://github.com/IQSS/dataverse-security/issues/98 . Should we link to it from the release notes for the people who have access?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some discussion here: https://iqss.slack.com/archives/C03R1E7T4KA/p1733507189175279

We decided to link to the security issue.

pdurbin and others added 2 commits December 5, 2024 16:13
Co-authored-by: Omer Fahim <[email protected]>
Co-authored-by: Omer Fahim <[email protected]>
@pdurbin pdurbin self-assigned this Dec 6, 2024
@sekmiller sekmiller self-assigned this Dec 9, 2024

## Settings Added

- `:GlobusBatchLookupSize`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a description/explanation here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've always had a "settings added" section and I think it's helpful to the sysadmins to always have this list to go to, even if it's short this time.


Replace schema.xml

Please note that the path to Solr may differ than the example below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we note the directory for developers deploying containers?

Copy link
Member Author

@pdurbin pdurbin Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the main audience is not developers so I don't think so. Maybe we should sent an email to the dev list?

@sekmiller
Copy link
Contributor

Looks good overall. I left a couple of comments/questions

@sekmiller sekmiller removed their assignment Dec 10, 2024
pdurbin and others added 2 commits December 10, 2024 10:59
Co-authored-by: Omer Fahim <[email protected]>
Co-authored-by: Omer Fahim <[email protected]>
Co-authored-by: Omer Fahim <[email protected]>
Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The one nit I have is that using the api/admin/index call (step 8) is not actually the one we talk about as reindex in place in the guides. That refers to deleting the time stamps for indexing and then calling continue. We could ignore this, just drop the 'reindex-in-place' phrase, or show the other calls. I'm not sure which is best - if the server is restarted before the /api/admin/index call completes, is there a way to restart like there is if you clear the index or delete the timestamps?

@pdurbin
Copy link
Member Author

pdurbin commented Dec 11, 2024

@qqmyers good catch. In 2de57e1 I removed "in place".

In other news, I saw the cvoc PR got merged so in fe13a43 I removed the snippet and worked it into the release notes.

@ofahimIQSS ofahimIQSS assigned ofahimIQSS and unassigned qqmyers Dec 11, 2024
@ofahimIQSS
Copy link
Contributor

reviewed and proof-read. Merging PR

@ofahimIQSS ofahimIQSS merged commit 5499549 into develop Dec 11, 2024
1 of 2 checks passed
@ofahimIQSS ofahimIQSS deleted the 10952-release-notes branch December 11, 2024 21:00
@ofahimIQSS ofahimIQSS removed their assignment Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) Size: 10 A percentage of a sprint. 7 hours.
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Release 6.5: Create release notes
4 participants