-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RO-Crate to guides #10796
Add RO-Crate to guides #10796
Conversation
(Also add Croissant)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I assume that as doc only, this can just get merged? (I did check that read the docs shows them formatted OK).
Yeah, docs get a fast track but up to you. Mostly I'm just trying to let people know about these exporters. |
Hi Phil, I saw the PR and your comment about not knowing how to explain the difference between the RO-Crate exporters, so below I’ll give it a shot:
I would actually be tempted to only provide the third one as a standard RO-Crate exporter, as the others are based on the transformer, which might be mentioned as its own thing that can be used to more easily create future exporters with as use cases/examples the ARP and Basic one. I would also rename the last one to “RO-Crate (adaptable)”.
And the work is being done by @okaradeniz to get the CSV one to work. |
@DieuwertjeBloemen thanks for all your thoughts on this. I like what you wrote, but where to put it? If you look at the files changed for this pull request, you can see that I'm really just suggesting that people learn more about these exporters over at https://github.com/gdcc/dataverse-exporters but the problem in that repo is that these long-ish descriptions don't fix so well in the table in the README: Perhaps instead of a table, we should have something else so that descriptions can be as long as necessary? (Perhaps every exporter should get a subheading.) Whatever we do, we should probably talk about it over in an issue at https://github.com/gdcc/dataverse-exporters/issues (please feel free to create one) or maybe in #docs in Zulip. @poikilotherm is the one who created the inventory table over there so we should get his thoughts. As I've said elsewhere, I'm also open to having the inventory in the guides themselves. |
Yeah, I guess it makes sense to add it somewhere over there, though it's not gonna fit in the overview table. I also get why a table might be nice to use to keep it clean and to the point. We could refer to the others in the RO-Crate one's page (https://github.com/gdcc/exporter-ro-crate). Though that might hide them a bit too much and make it so the table no longer has an overview of all available exporters... |
What this PR does / why we need it:
It's not easily discoverable in the guides that Dataverse supports RO-Crate because the implementation is outside the monolith.
In this pull request, near the link to the list of external metadata exporters (which is in a README in a separate repo), we highlight RO-Crate (and Croissant) so that people searching the guides for those terms can find them.
Which issue(s) this PR closes:
Special notes for your reviewer:
I'm definitely open to writing about RO-Crate somewhere in the User Guide (beyond a mention) but I couldn't find a good spot. Ideally, we'd have a specific place in the guides to link to from https://dataverse.org/software-features when we decide to call out RO-Crate support there (for every feature, we link to the guides). I'm open to suggestions!
Suggestions on how to test this:
No testing. It's just docs.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes, included. In the release note I was a little non-specific about the various RO-Crate exporters but there are three of them:
The first two seem to work fine but I know very little about RO-Crate and can't really comment if anything isn't in line with the spec.
The last I couldn't get working, as I reported here: #10744 (comment)
Additional documentation:
None.