-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8243 improve language controlled vocab #10481
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8796a1d
pushing the language controlled vocab additions suggested in #10197 i…
landreev 56f3b4b
Merge branch 'develop' into 8243-improve-language-controlled-vocab
landreev 4f8a74c
Alternative long spellings for the Slovene and Kyrgyz languages. #8243
landreev e3aa0e8
Merge branch 'develop' into 8243-improve-language-controlled-vocab
landreev f2f1ce1
Dropping the "macrolanguage" from the names of 2 language families, p…
landreev 5acb13a
Addresses the cases of languages with the names like "Navajo, Navaho"…
landreev 6324477
Fixed the tabs in the entries for Catalan and Haitian Creole; added t…
landreev 091ad21
One extra alternative name for Nuosu (from the ISO 893-2 articles on …
landreev d7a727f
a few minor cosmetic improvements (rearranging the 3 letter codes in …
landreev 8072d91
a release note. #8243
landreev a84d577
Merge branch 'develop' into 8243-improve-language-controlled-vocab
landreev 93fb1f5
Merge branch 'develop' into 8243-improve-language-controlled-vocab
landreev 1073333
Populated the identifier column in the Language CV, to make future up…
landreev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
doc/release-notes/8243-improve-language-controlled-vocab.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
The Controlled Vocabuary Values list for the metadata field Language in the Citation block has been improved, with some missing two- and three-letter ISO 639 codes added, as well as more alternative names for some of the languages, making all these extra language identifiers importable. | ||
|
||
To be added to the 6.3 release instructions: | ||
|
||
Update the Citation block, to incorporate the improved controlled vocabulary for language [plus whatever other improvements may be made to the block in other PRs]: | ||
|
||
``` | ||
wget https://raw.githubusercontent.com/IQSS/dataverse/v6.3/scripts/api/data/metadatablocks/citation.tsv | ||
curl http://localhost:8080/api/admin/datasetfield/load -H "Content-type: text/tab-separated-values" -X POST --upload-file citation.tsv | ||
``` | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a conversation going on where Youn Noh at Yale is proposing these changes:
Should we get this change in as well?
Please see https://groups.google.com/g/dataverse-community/c/rGkaHuzA2x4/m/GeyOF1kpAgAJ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pdurbin The change above doesn't make much sense, so no, we certainly don't want it as is. I'm going to add a comment in the google group thread reiterating an earlier suggestion for the author to take a closer look at the opening comment in this PR, since it answers some of the questions asked there.