IQSS/10324-fix granting file access w/o request

[qqmyers]

What this PR does / why we need it: To fix granting file access when there was no access request.

At QDR, this appears to be due to an npe:

Caused by: java.lang.NullPointerException: Cannot invoke "edu.harvard.iq.dataverse.FileAccessRequest.setStateGranted()" because "far" is null
        at edu.harvard.iq.dataverse.ManageFilePermissionsPage.grantAccess(ManageFilePermissionsPage.java:425)

Digging in the code a bit, it looks like a bug introduced with the guestboook-at-request PR: As of that PR, requests are not deleted when granted, they are now given the state granted. At the line in question, the code is looking for a request in the created state associated with the file, so if no request exists, it fails. That should mean that when granting access for one file w/o a request existing (didn't test), it would succeed but the success message/page update would fail. With more than one file, the files after the first access isn't granted.

Which issue(s) this PR closes:

Closes #10324

Special notes for your reviewer:

Suggestions on how to test this: See the issue and above. Regression testing - it should also work if someone requested access first.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

[coveralls]

coverage: 20.261% (-0.001%) from 20.262%
when pulling fbaec85 on QualitativeDataRepository:IQSS/10324-grant_file_access_without_request
into f456e51 on IQSS:develop.

[pdurbin]

I haven't tested the code but this is a very straightforward null check. Approved.

[stevenwinship]

@qqmyers @pdurbin

QA:
I tested multiple restricted files with a few requests which now passes (no null pointer exception).
I noticed a few other failures that may have nothing to do with this fix but wanted to check.
After granting access to a few of the requested files I then went to grant access to all the files. I received errors due to the fact that some of the grants were already allowed thus giving duplicate key errors from the DB.
Edit: it was the assign role that threw the exception since the role was already assigned in the DB.

See screenshots and stack trace.

stacktrace.txt

[stevenwinship]

I did verify that I had access to all files even though I saw the error in the UI for the file that was previously granted access

[qqmyers]

@stevenwinship - is the error you see also in the main codebase? It's hard to see how this PR could change things, but I could image it is an existing bug. If it is unique to this PR I can look again. If it is also in develop already, I'd suggest we start a new issue.