-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenShift prep work #10314
OpenShift prep work #10314
Conversation
To enable the user with a random, arbitrary UID to write into the overlay filesystem, we need to set proper file permissions. This should not affect users on Docker or other K8s distributions, as the security is more lenient there. It is not ideal to write into overlayfs, as it impacts performance and may lead to unintended side effects. This is a workaround to at least get going. See https://docs.openshift.com/container-platform/4.14/openshift_images/create-images.html#use-uid_create-images for a detailed reference
By defining pre- and postboot file locations within the Dockerfile, it wasn't able to change the location by changing CONFIG_DIR env var. This is fixed now, allowing simpler backing of the dir location with an (ephemeral) volume.
The location where to create the temporary file was wrong, fixed now.
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
As I've mentioned in Zulip and Slack, I'm having a little trouble with this PR. I'm getting 2024-02-15 update: @DanNiESh suggested the following change to
The root dataverse was created:
Once I forward the ports...
... I can get at the Dataverse web interface: There's still work to do with Solr, obviously, but this is great progress! Rather than spam this PR too much, I'm making noise in Zulip: https://dataverse.zulipchat.com/#narrow/stream/375812-containers/topic/OpenShift Also, we had a great conversation about all this in the container meeting today: recording, notes. |
This reverts commit 8547dbf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Will merge. Containers still run just fine with this prep work for OpenShift.
I just left this note at the top of the description to avoid confusion about what is being merged in this pull request:
We have narrowed the scope of this pull request. Its focus now is prep work for our images to run under OpenShift as any arbitrary user id. Plus some clean up.
We have reverted the commit (8547dbf) that added some Kubernetes config files (and added jkube as a dependency). We will pick up this work in the next issue:
Please note:
We have narrowed the scope of this pull request. Its focus now is prep work for our images to run under OpenShift as any arbitrary user id. Plus some clean up.
We have reverted the commit (8547dbf) that added some Kubernetes config files (and added jkube as a dependency). We will pick up this work in the next issue:
What this PR does / why we need it:
For MOC we wish to support running a proof of concept on OpenShift using our shiny containers.
This is also a testbed / preparation to enable folks to run Dataverse in production on more or less any Kubernetes distribution.
Which issue(s) this PR closes:
Special notes for your reviewer:
This is in its early stages. More to be done and discuss. Basically here to ease pushing new images with a tag to GHCR.
Suggestions on how to test this:
crc
as explained in their docs.crc start -c 8 -d 64 -m 16384
(8 CPU, 64Gi HDD, 16Gi RAM)oc port-forward pods/dataverse-X-X-X 8080
and then going to http://localhost:8080 with your browser.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
None
Is there a release notes update needed for this change?:
Maybe later
Additional documentation:
None (yet)