Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containers: set autodeploy-enabled=true for ENABLE_RELOAD #10100

Closed
wants to merge 1 commit into from

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Nov 4, 2023

What this PR does / why we need it:

We want the base image to support the autodeploy directory when ENABLE_RELOAD is true.

Which issue(s) this PR closes:

Suggestions on how to test this:

Try cp path/to/myapp.war /opt/payara/appserver/glassfish/domains/domain1/autodeploy with and without this fix.

@pdurbin pdurbin added the Component: Containers Anything related to cloudy Dataverse, shipped in containers. label Nov 4, 2023
@pdurbin pdurbin requested a review from poikilotherm November 4, 2023 22:33
@coveralls
Copy link

Coverage Status

coverage: 19.995%. remained the same
when pulling ad88002 on 10099-reload
into 3305c4a on develop.

@poikilotherm
Copy link
Contributor

@pdurbin this is included in the script now that #9959 was merged. Should we close this?

@pdurbin
Copy link
Member Author

pdurbin commented Mar 13, 2024

@poikilotherm ah, good point. I'll close this now and test it later. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENABLE_RELOAD=1 doesn't allow autodeploy to work in container base image
3 participants