Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Edit collection page type errors #571

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

g-saracca
Copy link
Contributor

What this PR does / why we need it:

This PR adds a typecheck script to the lint script.
It also updates Typescript to the latest version so it can Types Union Props that was causing the error.

Which issue(s) this PR closes:

Suggestions on how to test this:

Step 1: Run the Development Environment

  1. Execute npm i.
  2. Navigate with cd packages/design-system && npm i && npm run build.
  3. Return with cd ../../.
  4. Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000.
  5. Navigate with cd dev-env.
  6. Start the environment using ./run-env.sh unstable.
  7. To verify the environment, visit http://localhost:8000 and check your local Dataverse installation.

Step 2: Test the fix
Change something in the code that will throw a type error and then run npm run lint to validate that shows the error.

@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 SPA.Q4.10 Resolve TODOs and tech debt SPA labels Dec 16, 2024
@coveralls
Copy link

coveralls commented Dec 16, 2024

Coverage Status

coverage: 97.735% (+0.1%) from 97.634%
when pulling 9c09733 on fix/545-edit-collection-page-type-errors
into 66d2a60 on develop.

Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a warning about the typescript version, but that can be a separate issue. Approved 👍

@ofahimIQSS ofahimIQSS self-assigned this Dec 17, 2024
@cmbz cmbz added the FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) label Dec 17, 2024
@ofahimIQSS
Copy link
Contributor

tested - looks good

@ofahimIQSS ofahimIQSS merged commit a14929c into develop Dec 17, 2024
14 of 18 checks passed
@ofahimIQSS ofahimIQSS deleted the fix/545-edit-collection-page-type-errors branch December 17, 2024 16:41
@ofahimIQSS ofahimIQSS removed their assignment Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q4.10 Resolve TODOs and tech debt SPA
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Typescript update
5 participants