Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the skip from e2e test for getByPersistentId, so the test case could be included #543

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Remove the skip from e2e test for getByPersistentId, so the test case could be included #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
762b80c
fix: remove the skip so the test case could be included
ChengShi-1 Nov 4, 2024
fc131a4
fix: remove a todo which was wrongly copied and pasted
ChengShi-1 Nov 4, 2024
159058a
fix: add a criteria checking if it's deaccessioned
ChengShi-1 Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/sections/dataset/dataset-action-buttons/link-dataset-button/LinkDatasetButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ export function LinkDatasetButton({ dataset }: LinkDatasetButtonProps) {
const { t } = useTranslation('dataset')
const { user } = useSession()
const handleClick = () => {
// TODO - Implement upload files
showModal()
}
const { showModal } = useNotImplementedModal()
Expand Down
5 changes: 3 additions & 2 deletions tests/e2e-integration/integration/datasets/DatasetJSDataverseRepository.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,7 @@ describe('Dataset JSDataverse Repository', () => {
})
})

it.skip('gets the dataset by persistentId when the dataset is deaccessioned', async () => {
// TODO - Implement once the getDatasetCitation includes deaccessioned datasets
it('gets the dataset by persistentId when the dataset is deaccessioned', async () => {
const datasetResponse = await DatasetHelper.create(collectionId)

await DatasetHelper.publish(datasetResponse.persistentId)
Expand All @@ -337,8 +336,10 @@ describe('Dataset JSDataverse Repository', () => {
const datasetExpected = datasetData(dataset.persistentId, dataset.version.id)

expect(dataset.version.title).to.deep.equal(datasetExpected.title)
expect(dataset.version.publishingStatus).to.equal(DatasetPublishingStatus.DEACCESSIONED)
})
g-saracca marked this conversation as resolved.
Show resolved Hide resolved
})

it('gets the dataset by persistentId when is locked', async () => {
const datasetResponse = await DatasetHelper.create(collectionId)
await DatasetHelper.lock(datasetResponse.id, DatasetLockReason.FINALIZE_PUBLICATION)
Expand Down
Loading