-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich Text WYSIWYG Editor - Design System #529
Conversation
packages/design-system/tests/component/rich-text-editor/RichTextEditor.spec.tsx
Show resolved
Hide resolved
packages/design-system/tests/component/rich-text-editor/RichTextEditor.spec.tsx
Show resolved
Hide resolved
@ChengShi-1 empty lines added 👍🏼 , thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Approve.
Came across one observation - @ChengShi-1 can you confirm this is expected or a bug: Steps to Reproduce:
Issue: After adding the link, nothing happens (link not generated). |
Hi Omer! After adding a link, you can type your text, and it will appear blue and linked to the target web, you could open it in a new tab. Alternatively, you can type the text first, highlight the words, and then attach the link to those words. |
Testing of 529.docx |
What this PR does / why we need it:
Adds a new Rich Text Editor component to the design system.
This component is made with Tiptap npm packages.
Tiptap is a headless wrapper around ProseMirror – a toolkit for building rich text WYSIWYG editors, which is already in use at many well-known companies such as New York Times, The Guardian or Atlassian.
Cons: It does not support markdown as output, the output is html.
Pros:
Which issue(s) this PR closes:
Suggestions on how to test this:
Visual code inspection and Storybook story manual testing.
The component has 100% unit test coverage as well.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: