Configure storybook for data router #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
added
Size: 3
|
Tested and found no issues. Merging PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Configures storybook to use a data router instead of a memory router so we use the same router as we use in the actual application.
I also added a story for the error page that we were not able to add before with the memory router.
Which issue(s) this PR closes:
Suggestions on how to test this:
Step 1: Run SPA Storybook
npm i.cd packages/design-system && npm run build.cd ../../.npm run storybookand go to the SPA Storybook, the one on port 6006.Step 2: Test the feature
Check the storybook error page and verify that the SPA storybook keeps working correctly.
This change shouldn't affect any story behaviour.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
No.