Check/Format correct files with Prettier #523
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It fixes which files prettier was formatting/checking or not.
There are a lot of modified files but it is only because we are now formatting correctly with prettier html, tsx ts and scss files.
Which issue(s) this PR closes:
Special notes for your reviewer:
This issue should also close issue Fix Stylelint configuration .
'declaration-colon-space-after'
is now deprecated (see stylelint docs) so as long as you are using prettier with autosave it should format it correctly and if not we can always use thenpm run lint:fix
command mentioned in the Linting section from the DEVELOPER_GUIDE.Suggestions on how to test this:
What can be done is to incorrectly indent a
.tsx
file and a.scss
file and then run the commandnpm run lint:prettier
and validate that these two files are mentioned with errors.Then run
npm run lint:fix
to validate that this command fixes the indentation errors.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
No