-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/484 Collection page results of all types #509
Feat/484 Collection page results of all types #509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! I just have some minor comments.
src/sections/collection/collection-items-panel/CollectionItemsPanel.tsx
Outdated
Show resolved
Hide resolved
src/sections/collection/collection-items-panel/items-list/dataset-card/DatasetCardInfo.tsx
Show resolved
Hide resolved
src/sections/collection/collection-items-panel/search-panel/SearchPanel.tsx
Show resolved
Hide resolved
tests/component/sections/collection/collection-items-panel/CollectionItemsPanel.spec.tsx
Show resolved
Hide resolved
@ekraffmiller all requested changes are done except for the ones from unresolved conversations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you! Approving
What this PR does / why we need it:
getCollectionItems
use case to display collections, datasets and files in the collection page.Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the feature
First of all create collections, datasets and files within some of those datasets.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: Yes.
desktop_recording.mov
mobile_recording.mov
Is there a release notes update needed for this change?:
No
Additional documentation:
No