Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/461 publish collection #500

Merged
merged 25 commits into from
Oct 10, 2024
Merged

Feat/461 publish collection #500

merged 25 commits into from
Oct 10, 2024

Conversation

ekraffmiller
Copy link
Contributor

@ekraffmiller ekraffmiller commented Sep 23, 2024

What this PR does / why we need it:

Implements the integration and UI for Publish Collection

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Step 1: Run the Development Environment

  1. Execute npm i.
  2. Navigate with cd packages/design-system && npm run build.
  3. Return with cd ../../.
  4. Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000.
  5. Navigate with cd dev-env.
  6. Start the environment using ./run-env.sh unstable.
  7. To verify the environment, visit http://localhost:8000 and check your local Dataverse installation.

Step 2: Test the feature

In the SPA, create a new Collection.
From the Collection page, click 'Publish'
A modal will appear confirming the Publish action; click 'Continue'
The Collection Page will be displayed with a success message that the page was published.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

no

Is there a release notes update needed for this change?:

no

Additional documentation:

@coveralls
Copy link

coveralls commented Sep 23, 2024

Coverage Status

coverage: 97.463% (-0.07%) from 97.533%
when pulling 3ecad57 on feat/461-publish-collection
into 36c7b07 on develop.

@ekraffmiller ekraffmiller added SPA: Collection Page SPA.Q3.6 Publish Collection Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related labels Sep 23, 2024
@cmbz cmbz added the FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) label Sep 25, 2024
@ekraffmiller ekraffmiller marked this pull request as ready for review September 26, 2024 15:07
@g-saracca g-saracca self-assigned this Sep 27, 2024
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments on things to improve

g-saracca
g-saracca previously approved these changes Oct 2, 2024
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the requested changes, all the Storybook check reviews look good also, approving!

@g-saracca g-saracca removed their assignment Oct 2, 2024
g-saracca
g-saracca previously approved these changes Oct 3, 2024
@g-saracca g-saracca removed their assignment Oct 3, 2024
@ofahimIQSS ofahimIQSS self-assigned this Oct 9, 2024
@GPortas GPortas added SPA.Q4 Not related to any specific Q4 feature and removed SPA.Q3.6 Publish Collection labels Oct 9, 2024
@cmbz cmbz added the FY25 Sprint 8 FY25 Sprint 8 (2024-10-09 - 2024-10-23) label Oct 9, 2024
@ofahimIQSS
Copy link
Contributor

Testing completed in local. No issues found during testing.
Testing 500.docx

@ofahimIQSS ofahimIQSS merged commit ac7e2fc into develop Oct 10, 2024
13 of 14 checks passed
@ofahimIQSS ofahimIQSS deleted the feat/461-publish-collection branch October 10, 2024 20:05
@ofahimIQSS ofahimIQSS removed their assignment Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) FY25 Sprint 8 FY25 Sprint 8 (2024-10-09 - 2024-10-23) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Collection Page SPA.Q4 Not related to any specific Q4 feature
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Collection Page: Publish Collection
6 participants