-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/461 publish collection #500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few comments on things to improve
src/sections/collection/publish-collection/PublishCollectionModal.tsx
Outdated
Show resolved
Hide resolved
src/sections/collection/publish-collection/PublishCollectionModal.tsx
Outdated
Show resolved
Hide resolved
src/sections/collection/publish-collection/PublishCollectionModal.tsx
Outdated
Show resolved
Hide resolved
src/sections/collection/publish-collection/PublishCollectionModal.tsx
Outdated
Show resolved
Hide resolved
src/stories/collection/publish-collection/PublishCollectionModal.stories.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the requested changes, all the Storybook check reviews look good also, approving!
Co-authored-by: German Gonzalo Saracca <[email protected]>
Testing completed in local. No issues found during testing. |
What this PR does / why we need it:
Implements the integration and UI for Publish Collection
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the feature
In the SPA, create a new Collection.
From the Collection page, click 'Publish'
A modal will appear confirming the Publish action; click 'Continue'
The Collection Page will be displayed with a success message that the page was published.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no
Additional documentation: