-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/470 user panel api token #479
Conversation
…r-panel-api-token
…r-panel-api-token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question about text style.
Co-authored-by: Philip Durbin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! just need small updates and also a Story
…SS/dataverse-frontend into feat/470-user-panel-api-token
I added a basic story, when we integrate with the use cases we will be able to mock responses to show different scenarios. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, approved!
Hi German, the ui looks good and works well! I noticed that even without logging in, I was able to access the API token page by directly navigating to 'http://localhost:8000/spa/account?tab=apiToken'. Should we implement some measures to prevent unauthorized access to this page? |
Hi @ChengShi-1, yes, that is going to be solved when me merge the Private Routes Guards PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Approve.
What this PR does / why we need it:
This part of the documentation Users Token Management could be useful for developing use cases for managing api tokens from the SPA.
Which issue(s) this PR closes:
Special notes for your reviewer:
The rest of the tabs are disabled, only the API Token tab is enabled.
Also the Recreate Token and Revoke Token buttons are disabled.
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the feature
This is only UI work, but couple things could be tested.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: