Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/454 dataset page actions for draft #462

Merged
merged 9 commits into from
Sep 3, 2024

Conversation

g-saracca
Copy link
Contributor

What this PR does / why we need it:

Since the default dataset version has changed from :latest to :latest-published, more links need to updated to include&version=DRAFTwhen working with a draft version. The "Access Dataset", "Edit Metadata" and "FIle Upload" actions need to be updated to navigate to the correct dataset url.

Which issue(s) this PR closes:

Closes #454

Special notes for your reviewer:
There is also a fix for duplicate react keys on collection page dataset cards.

Suggestions on how to test this:

  • Create a Dataset, go to that Dataset and click the Edit Dataset => Files (Upload) should navigate correctly to the File Upload page. (version=DRAFT query param should be present on the URL)
  • Create a Dataset, go to that Dataset and click the Edit Dataset => Metadata should navigate correctly to the Edit dataset metadata page. (version=DRAFT query param should be present on the URL)
  • Publish that Dataset and navigate to the Files Upload & the Edit Dataset page. (version=DRAFT query param should NOT be present on the URL)
  • Access Dataset dropdown should not be visible when the Dataset has no files. Try uploading some files from the JSF version and check that in the Dataset View page on the SPA now the Access Dataset dropdown is visible and works correctly.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No

Is there a release notes update needed for this change?:
No

Additional documentation:
No

@g-saracca g-saracca added bug Something isn't working Size: 3 A percentage of a sprint. 2.1 hours. SPA: Dataset page (View) GREI Re-arch GREI re-architecture-related FY25 Sprint 3 FY25 Sprint 3 FY25 Sprint 4 FY25 Sprint 4 labels Aug 15, 2024
@coveralls
Copy link

coveralls commented Aug 15, 2024

Coverage Status

coverage: 97.368% (-0.2%) from 97.592%
when pulling 64987c3 on fix/454-dataset-page-actions-for-draft
into 393e926 on develop.

Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just found one place where I think we need to add the version=DRAFT logic.

@g-saracca g-saracca removed their assignment Aug 30, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@GPortas GPortas self-assigned this Sep 3, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested all scenarios and it works good!

@GPortas GPortas merged commit c71e287 into develop Sep 3, 2024
11 of 14 checks passed
@GPortas GPortas deleted the fix/454-dataset-page-actions-for-draft branch September 3, 2024 15:06
@GPortas GPortas added SPA.Q3 Not related to any specific Q3 feature Original size: 3 labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FY25 Sprint 3 FY25 Sprint 3 FY25 Sprint 4 FY25 Sprint 4 FY25 Sprint 5 FY25 sprint 5 GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Dataset page (View) SPA.Q3 Not related to any specific Q3 feature
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Dataset Page Actions not working for draft versions
5 participants