-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/454 dataset page actions for draft #462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just found one place where I think we need to add the version=DRAFT logic.
src/sections/dataset/dataset-files/dataset-upload-files-button/DatasetUploadFilesButton.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested all scenarios and it works good!
What this PR does / why we need it:
Which issue(s) this PR closes:
Closes #454
Special notes for your reviewer:
There is also a fix for duplicate react keys on collection page dataset cards.
Suggestions on how to test this:
version=DRAFT
query param should be present on the URL)version=DRAFT
query param should be present on the URL)version=DRAFT
query param should NOT be present on the URL)Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
No