fix: button acting as anchor

IQSS · Dec 11, 2023 · c0644b1 · c0644b1
1 parent 5b352ee
commit c0644b1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/...ons/dataset/dataset-files/files-table/file-actions/download-files/DownloadFilesButton.tsx b/...ons/dataset/dataset-files/files-table/file-actions/download-files/DownloadFilesButton.tsx
@@ -70,14 +70,15 @@ export function DownloadFilesButton({ files, fileSelection }: DownloadFilesButto
 
   return (
     <>
-      <Button
-        variant="secondary"
-        icon={<Download className={styles.icon} />}
-        withSpacing
-        onClick={onClick}
-        href={getDownloadUrl(FileDownloadMode.ORIGINAL)}>
-        {t('actions.downloadFiles.title')}
-      </Button>
+      <a href={getDownloadUrl(FileDownloadMode.ORIGINAL)}>
+        <Button
+          variant="secondary"
+          icon={<Download className={styles.icon} />}
+          withSpacing
+          onClick={onClick}>
+          {t('actions.downloadFiles.title')}
+        </Button>
+      </a>
       <NoSelectedFilesModal
         show={showNoFilesSelectedModal}
         handleClose={() => setShowNoFilesSelectedModal(false)}

diff --git a/...ataset/dataset-files/files-table/file-actions/download-files/DownloadFilesButton.spec.tsx b/...ataset/dataset-files/files-table/file-actions/download-files/DownloadFilesButton.spec.tsx
@@ -147,11 +147,9 @@ describe('DownloadFilesButton', () => {
       </MultipleFileDownloadProvider>
     )
 
-    cy.findByRole('button', { name: 'Download' }).should(
-      'have.attr',
-      'href',
-      'https://some-download-url'
-    )
+    cy.findByRole('button', { name: 'Download' })
+      .parent('a')
+      .should('have.attr', 'href', 'https://some-download-url')
   })
 
   it('renders the download url for the selected files when some files are selected and there are tabular files', () => {