tests: complete most of the test cases

IQSS · Nov 14, 2024 · 6502c80 · 6502c80
1 parent 1afcaa8
commit 6502c80
Show file tree

Hide file tree

Showing 4 changed files with 962 additions and 826 deletions.
diff --git a/src/sections/shared/form/EditCreateCollectionForm/CollectionFormHelper.ts b/src/sections/shared/form/EditCreateCollectionForm/CollectionFormHelper.ts
@@ -222,6 +222,10 @@ export class CollectionFormHelper {
   public static formatCollectionContactsToFormContacts(
     collectionContacts: CollectionContact[]
   ): CollectionFormContactValue[] {
+    if (collectionContacts.length === 0) {
+      return [{ value: '' }]
+    }
+
     return collectionContacts.map((contact) => ({
       value: contact.email
     }))

diff --git a/src/sections/shared/form/EditCreateCollectionForm/EditCreateCollectionForm.tsx b/src/sections/shared/form/EditCreateCollectionForm/EditCreateCollectionForm.tsx
@@ -32,7 +32,7 @@ type EditCreateCollectionFormProps =
   | {
       mode: 'create'
       user: User
-      collection?: never
+      collection?: never // In create mode, collection is undefined, we only have parentCollection
       parentCollection: Collection
       collectionRepository: CollectionRepository
       metadataBlockInfoRepository: MetadataBlockInfoRepository
@@ -41,7 +41,7 @@ type EditCreateCollectionFormProps =
       mode: 'edit'
       user: User
       collection: Collection
-      parentCollection?: ParentCollectionDataInEdition
+      parentCollection?: ParentCollectionDataInEdition // In edit mode, parentCollection could be undefined in case of root collection
       collectionRepository: CollectionRepository
       metadataBlockInfoRepository: MetadataBlockInfoRepository
     }
@@ -104,7 +104,7 @@ export const EditCreateCollectionForm = ({
   }, [allMetadataBlocksInfo])
 
   const collectionInputLevelsToFormat =
-    mode === 'edit' ? collection?.inputLevels : parentCollection?.inputLevels
+    mode === 'edit' ? collection.inputLevels : parentCollection.inputLevels
 
   const formattedCollectionInputLevels: FormattedCollectionInputLevelsWithoutParentBlockName =
     useDeepCompareMemo(() => {

diff --git a/tests/component/sections/shared/edit-create-collection-form/CollectionFormHelper.spec.ts b/tests/component/sections/shared/edit-create-collection-form/CollectionFormHelper.spec.ts
@@ -579,6 +579,14 @@ describe('CollectionFormHelper', () => {
     expect(result).to.deep.equal(expected)
   })
 
+  it('formats empty collection contacts to empty form contacts values ', () => {
+    const collectionContacts: CollectionContact[] = []
+
+    const result = CollectionFormHelper.formatCollectionContactsToFormContacts(collectionContacts)
+
+    expect(result).to.deep.equal([{ value: '' }])
+  })
+
   describe('defineShouldCheckUseFromParent', () => {
     it('returns false if is on edit mode and is editing the root collection', () => {
       const result = CollectionFormHelper.defineShouldCheckUseFromParent(true, true, true)