feat(DeaccessionedFiles): implement integration test

IQSS · Oct 4, 2023 · 35ac5c4 · 35ac5c4
1 parent 15e1ffb
commit 35ac5c4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/files/infrastructure/mappers/JSFileMapper.ts b/src/files/infrastructure/mappers/JSFileMapper.ts
@@ -82,14 +82,14 @@ export class JSFileMapper {
   ): FileVersion {
     const fileVersion = { number: jsVersion, publishingStatus: FilePublishingStatus.DRAFT }
 
-    if (datasetVersion.publishingStatus === DatasetPublishingStatus.DEACCESSIONED) {
-      fileVersion.publishingStatus = FilePublishingStatus.DEACCESSIONED
-    }
-
     if (jsPublicationDate) {
       fileVersion.publishingStatus = FilePublishingStatus.RELEASED
     }
 
+    if (datasetVersion.publishingStatus === DatasetPublishingStatus.DEACCESSIONED) {
+      fileVersion.publishingStatus = FilePublishingStatus.DEACCESSIONED
+    }
+
     return fileVersion
   }
 

diff --git a/tests/e2e-integration/integration/files/FileJSDataverseRepository.spec.ts b/tests/e2e-integration/integration/files/FileJSDataverseRepository.spec.ts
@@ -156,7 +156,7 @@ describe('File JSDataverse Repository', () => {
         })
     })
 
-    it.skip('gets all the files by dataset persistentId after dataset deaccession', async () => {
+    it.only('gets all the files by dataset persistentId after dataset deaccession', async () => {
       const dataset = await DatasetHelper.createWithFiles(FileHelper.createMany(3)).then(
         (datasetResponse) => datasetRepository.getByPersistentId(datasetResponse.persistentId)
       )
@@ -170,7 +170,6 @@ describe('File JSDataverse Repository', () => {
       await TestsUtils.wait(1500) // Wait for the dataset to be deaccessioned
       await TestsUtils.wait(1500) // Wait for the dataset to be deaccessioned
 
-      // TODO - It always returns 404 when the dataset is deaccessioned, update the test when the issue is fixed
       await fileRepository
         .getAllByDatasetPersistentId(
           dataset.persistentId,