chore: fix lint errors

IQSS · Jun 26, 2024 · 2bba5bb · 2bba5bb
1 parent efb61d4
commit 2bba5bb
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 8 deletions.
diff --git a/...rm/MetadataForm/MetadataBlockFormFields/MetadataFormField/Fields/ComposeFieldMultiple.tsx b/...rm/MetadataForm/MetadataBlockFormFields/MetadataFormField/Fields/ComposeFieldMultiple.tsx
@@ -44,7 +44,7 @@ export const ComposedFieldMultiple = ({
             .filter(([_, metadataField]) => metadataField.isRequired)
             .map(([key, _]) => key)
         : [],
-    []
+    [childMetadataFields, notRequiredWithChildFieldsRequired]
   )
 
   const childFieldNamesThatTriggerRequired = useMemo(
@@ -54,7 +54,7 @@ export const ComposedFieldMultiple = ({
             .filter(([_, metadataField]) => !metadataField.isRequired)
             .map(([key, _]) => key)
         : [],
-    []
+    [childMetadataFields, notRequiredWithChildFieldsRequired]
   )
 
   const handleOnAddField = (index: number) => {

diff --git a/...adataForm/MetadataForm/MetadataBlockFormFields/MetadataFormField/Fields/ComposedField.tsx b/...adataForm/MetadataForm/MetadataBlockFormFields/MetadataFormField/Fields/ComposedField.tsx
@@ -31,7 +31,7 @@ export const ComposedField = ({
             .filter(([_, metadataField]) => metadataField.isRequired)
             .map(([key, _]) => key)
         : [],
-    []
+    [childMetadataFields, notRequiredWithChildFieldsRequired]
   )
 
   const childFieldNamesThatTriggerRequired = useMemo(
@@ -41,7 +41,7 @@ export const ComposedField = ({
             .filter(([_, metadataField]) => !metadataField.isRequired)
             .map(([key, _]) => key)
         : [],
-    []
+    [childMetadataFields, notRequiredWithChildFieldsRequired]
   )
 
   return (

diff --git a/...tMetadataForm/MetadataForm/MetadataBlockFormFields/MetadataFormField/Fields/Primitive.tsx b/...tMetadataForm/MetadataForm/MetadataBlockFormFields/MetadataFormField/Fields/Primitive.tsx
@@ -67,7 +67,7 @@ export const Primitive = ({
       }
     }
     return rulesToApply
-  }, [rulesToApply, fieldShouldBecomeRequired])
+  }, [rulesToApply, fieldShouldBecomeRequired, displayName, isFieldThatMayBecomeRequired, t])
 
   const isTextArea = type === TypeMetadataFieldOptions.Textbox
 

diff --git a/...MetadataForm/MetadataForm/MetadataBlockFormFields/MetadataFormField/Fields/Vocabulary.tsx b/...MetadataForm/MetadataForm/MetadataBlockFormFields/MetadataFormField/Fields/Vocabulary.tsx
@@ -67,7 +67,7 @@ export const Vocabulary = ({
       }
     }
     return rulesToApply
-  }, [rulesToApply, fieldShouldBecomeRequired])
+  }, [rulesToApply, fieldShouldBecomeRequired, displayName, isFieldThatMayBecomeRequired, t])
 
   return (
     <Controller

diff --git a/...adataForm/MetadataBlockFormFields/MetadataFormField/useWatchFieldsThatTriggerRequired.tsx b/...adataForm/MetadataBlockFormFields/MetadataFormField/useWatchFieldsThatTriggerRequired.tsx
@@ -21,7 +21,7 @@ const useWatchFieldsThatTriggerRequired = ({ fieldsToWatch, builtFieldName }: Pr
     if (!fieldShouldBecomeRequired) {
       clearErrors(builtFieldName)
     }
-  }, [fieldShouldBecomeRequired])
+  }, [fieldShouldBecomeRequired, builtFieldName, clearErrors])
 
   return fieldShouldBecomeRequired
 }

diff --git a/tests/component/sections/shared/dataset-metadata-form/DatasetMetadataForm.spec.tsx b/tests/component/sections/shared/dataset-metadata-form/DatasetMetadataForm.spec.tsx
@@ -1,4 +1,3 @@
-import { fireEvent } from '@testing-library/react'
 import { MetadataBlockName } from '../../../../../src/dataset/domain/models/Dataset'
 import { DatasetRepository } from '../../../../../src/dataset/domain/repositories/DatasetRepository'
 import { TypeMetadataFieldOptions } from '../../../../../src/metadata-block-info/domain/models/MetadataBlockInfo'