Skip to content

Commit

Permalink
Merge pull request #550 from IQSS/537-upgrade-to-v4-download-upload-a…
Browse files Browse the repository at this point in the history
…rtifacts

Upgrade to v4 download and upload artifacts
  • Loading branch information
ofahimIQSS authored Nov 25, 2024
2 parents 88d218a + f5159bf commit 02b04e5
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 6 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/deploy-beta-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,11 @@ jobs:
- name: Build with base path
run: npm run build -- --base=/spa

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: built-site
path: ./dist
include-hidden-files: true

deploy-to-payara:
needs: build
Expand All @@ -58,7 +59,7 @@ jobs:
distribution: 'zulu'
java-version: '11'

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: built-site
path: ./dist
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,11 @@ jobs:
if: ${{ github.event.inputs.infra_type == 'Payara' && github.event.inputs.basepath != '' }}
run: npm run build -- --base=/${{ github.event.inputs.basepath }}

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: built-site
path: ./dist
include-hidden-files: true

deploy-to-s3:
needs: build
Expand All @@ -84,7 +85,7 @@ jobs:
python -m pip install --upgrade pip
pip install awscli
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: built-site
path: ./dist
Expand All @@ -111,7 +112,7 @@ jobs:
distribution: 'zulu'
java-version: '11'

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: built-site
path: ./dist
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Upload Cypress screenshots
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress-screenshots
Expand Down
14 changes: 14 additions & 0 deletions tests/component/sections/dataset/Dataset.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@ import { FileAccessOption, FileTag } from '../../../../src/files/domain/models/F
import { AlertProvider } from '../../../../src/sections/alerts/AlertProvider'
import { MetadataBlockInfoRepository } from '../../../../src/metadata-block-info/domain/repositories/MetadataBlockInfoRepository'
import { MetadataBlockInfoMother } from '../../metadata-block-info/domain/models/MetadataBlockInfoMother'
import { CollectionRepository } from '@/collection/domain/repositories/CollectionRepository'

const setAnonymizedView = () => {}
const fileRepository: FileRepository = {} as FileRepository
const datasetRepository: DatasetRepository = {} as DatasetRepository
const metadataBlockInfoRepository: MetadataBlockInfoRepository = {} as MetadataBlockInfoRepository
const collectionRepository: CollectionRepository = {} as CollectionRepository

const TOTAL_FILES_COUNT = 200
const allFiles = FilePreviewMother.createMany(TOTAL_FILES_COUNT)
Expand Down Expand Up @@ -93,6 +95,7 @@ describe('Dataset', () => {
datasetRepository={datasetRepository}
fileRepository={fileRepository}
metadataBlockInfoRepository={metadataBlockInfoRepository}
collectionRepository={collectionRepository}
/>,
testDataset
)
Expand All @@ -109,6 +112,7 @@ describe('Dataset', () => {
datasetRepository={datasetRepository}
fileRepository={fileRepository}
metadataBlockInfoRepository={metadataBlockInfoRepository}
collectionRepository={collectionRepository}
/>,
emptyDataset
)
Expand All @@ -124,6 +128,7 @@ describe('Dataset', () => {
datasetRepository={datasetRepository}
fileRepository={fileRepository}
metadataBlockInfoRepository={metadataBlockInfoRepository}
collectionRepository={collectionRepository}
/>,
dataset
)
Expand All @@ -140,6 +145,7 @@ describe('Dataset', () => {
datasetRepository={datasetRepository}
fileRepository={fileRepository}
metadataBlockInfoRepository={metadataBlockInfoRepository}
collectionRepository={collectionRepository}
/>,
dataset
)
Expand All @@ -155,6 +161,7 @@ describe('Dataset', () => {
datasetRepository={datasetRepository}
fileRepository={fileRepository}
metadataBlockInfoRepository={metadataBlockInfoRepository}
collectionRepository={collectionRepository}
/>,
testDataset
)
Expand All @@ -171,6 +178,7 @@ describe('Dataset', () => {
datasetRepository={datasetRepository}
fileRepository={fileRepository}
metadataBlockInfoRepository={metadataBlockInfoRepository}
collectionRepository={collectionRepository}
/>,
testDataset
)
Expand All @@ -190,6 +198,7 @@ describe('Dataset', () => {
datasetRepository={datasetRepository}
fileRepository={fileRepository}
metadataBlockInfoRepository={metadataBlockInfoRepository}
collectionRepository={collectionRepository}
/>,
testDataset
)
Expand All @@ -212,6 +221,7 @@ describe('Dataset', () => {
datasetRepository={datasetRepository}
fileRepository={fileRepository}
metadataBlockInfoRepository={metadataBlockInfoRepository}
collectionRepository={collectionRepository}
/>,
testDatasetAnonymized
)
Expand All @@ -229,6 +239,7 @@ describe('Dataset', () => {
datasetRepository={datasetRepository}
fileRepository={fileRepository}
metadataBlockInfoRepository={metadataBlockInfoRepository}
collectionRepository={collectionRepository}
/>,
testDataset
)
Expand All @@ -245,6 +256,7 @@ describe('Dataset', () => {
fileRepository={fileRepository}
metadataBlockInfoRepository={metadataBlockInfoRepository}
filesTabInfiniteScrollEnabled={true}
collectionRepository={collectionRepository}
/>,
testDataset
)
Expand All @@ -262,6 +274,7 @@ describe('Dataset', () => {
datasetRepository={datasetRepository}
fileRepository={fileRepository}
metadataBlockInfoRepository={metadataBlockInfoRepository}
collectionRepository={collectionRepository}
created={true}
/>
</AlertProvider>,
Expand All @@ -281,6 +294,7 @@ describe('Dataset', () => {
datasetRepository={datasetRepository}
fileRepository={fileRepository}
metadataBlockInfoRepository={metadataBlockInfoRepository}
collectionRepository={collectionRepository}
metadataUpdated={true}
/>
</AlertProvider>,
Expand Down

0 comments on commit 02b04e5

Please sign in to comment.