Skip to content

fix: remove a todo which was wrongly copied and pasted #2238

fix: remove a todo which was wrongly copied and pasted

fix: remove a todo which was wrongly copied and pasted #2238

Status Success
Total duration 2m 49s
Artifacts

lint.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

8 warnings
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint: src/sections/dataset/dataset-files/files-table/row-selection/useFileSelection.ts#L75
React Hook useEffect has a missing dependency: 'updateFileSelection'. Either include it or remove the dependency array
lint: src/sections/dataset/dataset-files/files-table/row-selection/useFileSelection.ts#L79
React Hook useEffect has missing dependencies: 'computeCurrentPageRowSelection' and 'setCurrentPageRowSelection'. Either include them or remove the dependency array. If 'setCurrentPageRowSelection' changes too often, find the parent component that defines it and wrap that definition in useCallback
lint: src/sections/dataset/dataset-files/useFiles.tsx#L75
React Hook useEffect has missing dependencies: 'getFiles' and 'getFilesCountInfo'. Either include them or remove the dependency array
lint: src/sections/shared/pagination/PaginationControls.tsx#L45
React Hook useEffect has missing dependencies: 'onPaginationInfoChange' and 'paginationInfo'. Either include them or remove the dependency array. If 'onPaginationInfoChange' changes too often, find the parent component that defines it and wrap that definition in useCallback
lint: src/sections/shared/pagination/PaginationControls.tsx#L55
React Hook useEffect has missing dependencies: 'onPaginationInfoChange', 'paginationInfo', 'searchParams', 'setSearchParams', and 'updateQueryParam'. Either include them or remove the dependency array. If 'onPaginationInfoChange' changes too often, find the parent component that defines it and wrap that definition in useCallback
lint: src/sections/shared/pagination/PaginationControls.tsx#L59
React Hook useEffect has a missing dependency: 'paginationInfo'. Either include it or remove the dependency array. You can also do a functional update 'setPaginationInfo(p => ...)' if you only need 'paginationInfo' in the 'setPaginationInfo' call
lint: src/sections/shared/pagination/PaginationControls.tsx#L70
React Hook useEffect has missing dependencies: 'goToPage', 'paginationInfo.page', 'setSearchParams', and 'updateQueryParam'. Either include them or remove the dependency array