Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep to release 0.3.8 to CRAN #99

Merged
merged 23 commits into from
Apr 14, 2021
Merged

Prep to release 0.3.8 to CRAN #99

merged 23 commits into from
Apr 14, 2021

Conversation

wibeasley
Copy link
Contributor

@kuriwaki, this is basically your modification (#94), plus updating the testing infrastructure (#96, #97, & #98)

kuriwaki and others added 19 commits April 12, 2021 17:13
@kuriwaki
Make dataverse example (under dontrun) more realistic
e3c880a
@wibeasley
testthat::skip_on_cran() for all server tests
0758fe7 
ref #96
@wibeasley
remove deprecated testthat::context()
b0f2410 
https://testthat.r-lib.org/reference/context.html
@wibeasley
upgrade testthat to 3.0 edition
310156b 
close #97
@wibeasley
Starting GitHub Actions
9635551 
ref #98
@wibeasley
check on dev branch
b73b4a6 
ref #98
@wibeasley
remove tests for older versions of R
d6b1a6d
@wibeasley
ignore vignett's doc/
0818e44
@wibeasley
havea simple & a thorough GitHub Action
8606004 
ref #98
@wibeasley
daily tests run 3:07am
903b40d 
ref #98
@wibeasley
changing name of tests
e688515 
ref #98
@wibeasley
trying to figure out why httr isn't available
9c4b3bb 
see https://github.com/IQSS/dataverse-client-r/actions/runs/745908113

ref #98
@wibeasley
as cran; error on warnings
151b560 
ref #98
@wibeasley
copy from REDCapR
42e5cc0 
see https://github.com/OuhscBbmc/REDCapR/blob/master/.github/workflows/check-release.yaml

ref #98

Trying to fix a missing httr error:  https://github.com/IQSS/dataverse-client-r/runs/2337223042?check_suite_focus=true#step:5:17
@wibeasley
ubuntu latest
d4bda51 
instead of hard coding 18.04

ref #98
@wibeasley
delete travis yaml file
ccde16e 
ref #98
@wibeasley
try to avoid hard-coded rspms
032976b 
ref #98
@wibeasley
remove rspms
d32225a 
ref #98
@wibeasley
update news & readme
6b0dfa7 
close #98; close #96
@wibeasley wibeasley requested a review from kuriwaki April 13, 2021 23:13
@wibeasley wibeasley self-assigned this Apr 13, 2021
@kuriwaki
Copy link
Member

The changes here are substantial but don't seem to affect the front-end user. I was thinking of reserving v0.4.0 for when we fix the bugs in create_* (#82, #23). What do you think about naming this 0.3.8? Version numbers make no substantial difference of course so I'm ok either way; just a thought.

kuriwaki
kuriwaki approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@kuriwaki kuriwaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the test infrastructure. I also added unrelated updates to the example code (which is still under dontrun)

@wibeasley wibeasley changed the title Prep to release 0.4.0 to CRAN Prep to release 0.3.8 to CRAN Apr 14, 2021
@wibeasley wibeasley merged commit d134a8c into master Apr 14, 2021
@wibeasley wibeasley mentioned this pull request Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuriwaki kuriwaki kuriwaki approved these changes

Assignees

@wibeasley wibeasley

Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wibeasley @kuriwaki