-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add use cases to get the zip download limit and embargo duration in months #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a comment about splitting a test
Hopefully the dataverse branches this PR depends on get merged soon
… into 84-read-settings
…ration test splitted
There are use cases whose integration tests are failing, that is normal, since the Dataverse branch used in this PR does not include all endpoints due to Dataverse PRs not yet merged. |
@GPortas I know, but should the integration tests point to DATAVERSE_IMAGE_TAG=9880-info-zip-download-limit-embargo ? branch 9880 is already merged into develop so maybe you can point to the develop image tag so when the other files PR get merged into develop the integration tests work I'm ready to approve this, just wanted to comment that |
I agree. In fact, in an ideal scenario the develop branch of this repository should always point to dataverse develop branch image (unstable tag). Updating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What this PR does / why we need it:
We need these new cases since they are necessary for the SPA to show the related functionality.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Tests related to files are failing, since the Dataverse branch they are pointing to does not have the files API extension. Therefore, this PR must wait for the PR IQSS/dataverse#9853 to be merged and IQSS/dataverse#9881 to be updated with develop.
Suggestions on how to test this:
Is there a release notes update needed for this change?:
Add GetZipDownloadLimit and GetMaxEmbargoDurationInMonths use cases
Additional documentation:
None