Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file creation date and publication date in FileModel from date object to string type #226

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ChengShi-1
Copy link
Contributor

What this PR does / why we need it:

Change the e file creation date and publication date from Date object to string type(as same as the payload format) to avoid a date conflict

Which issue(s) this PR closes:

Related Dataverse PRs:

  • Depends on #

Special notes for your reviewer:

Suggestions on how to test this:

  • run unit test and integration test on it

Is there a release notes update needed for this change?:

Additional documentation:

@ChengShi-1 ChengShi-1 added FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) GREI Re-arch GREI re-architecture-related Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 SPA.Q4.10 Resolve TODOs and tech debt SPA: File Page labels Dec 4, 2024
@ChengShi-1 ChengShi-1 added the FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) label Dec 4, 2024
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approving.
Do we need changes on the frontend repo for this? Maybe typescript interface updates?

@ChengShi-1
Copy link
Contributor Author

Looks good! Approving. Do we need changes on the frontend repo for this? Maybe typescript interface updates?

@g-saracca Hi German, thanks for reviewing. Yes, I created an issue for front-end changes. IQSS/dataverse-frontend#560

@ofahimIQSS
Copy link
Contributor

Merging PR - IT Tests passing

@ofahimIQSS ofahimIQSS merged commit 68639c4 into develop Dec 18, 2024
5 checks passed
@ofahimIQSS ofahimIQSS deleted the 223-Change-file-creation-date branch December 18, 2024 15:06
@ofahimIQSS ofahimIQSS removed their assignment Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: File Page SPA.Q4.10 Resolve TODOs and tech debt
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Change file creation date and publication date in FileModel from date object to string type
3 participants