Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

102 get dataset citation deaccessioned #105

Merged
merged 9 commits into from
Dec 20, 2023
Merged

102 get dataset citation deaccessioned #105

merged 9 commits into from
Dec 20, 2023

Conversation

ekraffmiller
Copy link
Contributor

What this PR does / why we need it:

This PR modifies the call to the get citation API, to return citation for a deaccessioned dataset.

Which issue(s) this PR closes:

Related Dataverse PRs:

  • Depends on #

Special notes for your reviewer:

Suggestions on how to test this:

Run the integration test, which gets the citation for a deaccessioned dataset.

Is there a release notes update needed for this change?:

no

Additional documentation:

@ekraffmiller ekraffmiller marked this pull request as ready for review November 30, 2023 21:24
@ekraffmiller ekraffmiller added the Size: 3 A percentage of a sprint. 2.1 hours. label Dec 6, 2023
@MellyGray MellyGray self-assigned this Dec 15, 2023
@MellyGray MellyGray assigned ekraffmiller and unassigned MellyGray Dec 15, 2023
@ekraffmiller
Copy link
Contributor Author

Hi @MellyGray I made the changes you recommended, except I had a problem moving the code that waits for Datset Locks into datasetHelper. Let me know if you can see what I'm doing wrong, or if you want to go over it together.

@GPortas GPortas requested a review from MellyGray December 19, 2023 12:39
MellyGray
MellyGray reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested changes were applied but check my comment about the locks in the integration test

@MellyGray MellyGray assigned ekraffmiller and unassigned MellyGray Dec 19, 2023
@ekraffmiller
Copy link
Contributor Author

Thanks @MellyGray, I removed the unneeded code

MellyGray
MellyGray approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved

@MellyGray MellyGray removed their assignment Dec 19, 2023
@GPortas GPortas self-assigned this Dec 20, 2023
@GPortas GPortas merged commit a16dd1c into develop Dec 20, 2023
2 checks passed
@GPortas GPortas deleted the 102-getDatasetCitation-deaccessioned branch December 20, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MellyGray MellyGray MellyGray approved these changes

@GPortas GPortas GPortas approved these changes

Assignees

@GPortas GPortas

Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify getDatasetCitation use case to retrieve citation information of a deaccessioned dataset
3 participants
@ekraffmiller @GPortas @MellyGray