-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset extension #27
base: master
Are you sure you want to change the base?
Conversation
Hi. There was a bit of a delay on this but as we talked about a few months ago these are the changes I needed to be able to extend this client for use with our dataverse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me but I'll leave it to the maintainers to decide.
Hi Gaby sorry struggling to find time to work on this. Im no longer working
in any area related to Dataverse. @pdurbin would anyone at Dataverse be
able to take on this project?
…On Fri, 16 Jun 2023, 1:25 pm Gaby, ***@***.***> wrote:
Some methods were passed from private to protected so that they could be
overriden while extending their class.
------------------------------
You can view, comment on, or merge this pull request online at:
#27
Commit Summary
- cc22cd7
<cc22cd7>
Changed methods to protected to alow for extension
- 15e3e17
<15e3e17>
Modified aditional method for extension
File Changes
(3 files <https://github.com/IQSS/dataverse-client-java/pull/27/files>)
- *M*
src/main/java/com/researchspace/dataverse/entities/facade/DatasetBuilder.java
<https://github.com/IQSS/dataverse-client-java/pull/27/files#diff-cab2976617fb35277a61a94d0c1dbfcb86b159f30ef9c9b2f1241ad270e0b796>
(42)
- *M*
src/main/java/com/researchspace/dataverse/http/AbstractOpsImplV1.java
<https://github.com/IQSS/dataverse-client-java/pull/27/files#diff-b2f1258fe7b61eeedc66ee9ba6498585a039c6d09b80d275eb955e1b568a9786>
(4)
- *M*
src/main/java/com/researchspace/dataverse/http/DataverseOperationsImplV1.java
<https://github.com/IQSS/dataverse-client-java/pull/27/files#diff-735318d203c08be98288eef2041541969793f6ca49cd389293919d210a3d1974>
(6)
Patch Links:
- https://github.com/IQSS/dataverse-client-java/pull/27.patch
- https://github.com/IQSS/dataverse-client-java/pull/27.diff
—
Reply to this email directly, view it on GitHub
<#27>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACIDVHJRI6V4V3Q3A6O6USDXLRGC7ANCNFSM6AAAAAAZJF54DY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@otter606 honestly, probably not but for the R client we've seen the torch pass from one maintainer to another. And for pyDataverse, the process is ongoing. You could always post a "seeking a new maintainer!" issue like this one: @otter606 I appreciate all the time you've put into the Java client over the years! 🎉 ❤️ |
Some methods were passed from private to protected so that they could be overriden while extending their class.