Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset extension #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gabriel-Besombes
Copy link

Some methods were passed from private to protected so that they could be overriden while extending their class.

@Gabriel-Besombes
Copy link
Author

Hi. There was a bit of a delay on this but as we talked about a few months ago these are the changes I needed to be able to extend this client for use with our dataverse.
I also added the possibility to set a metadata language by extending the DataverseOperationsImplV1 class so that it accepts it as a parameter for the createDataset method. From what I could understand this is part of the dataverse standard so if you want it I can make a second pull request for that change instead.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me but I'll leave it to the maintainers to decide.

@otter606
Copy link
Contributor

otter606 commented Jun 19, 2023 via email

@pdurbin
Copy link
Member

pdurbin commented Jun 21, 2023

@otter606 honestly, probably not but for the R client we've seen the torch pass from one maintainer to another. And for pyDataverse, the process is ongoing.

You could always post a "seeking a new maintainer!" issue like this one:

@otter606 I appreciate all the time you've put into the Java client over the years! 🎉 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants