[FIX] UI: create client-side random ids in any context. #8747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibsy
added
kitchen sink
improvement
javascript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
I have introduced the usage of
cryptoinside our newTemplateRendererto generate random strings. We noticed however that this object is only available in a secure context, which is not always the case for ILIAS - especially during development.We also noticed that the
URLBuilderTokenimplements a random string generation, similar to the use case of ourTemplateRenderer. I therefore decided to introduce a newcreateRandomString()function which covers both of these usages. These strings are not cryptographically secure, but they are random enough for what they are used for.Kind regards,
@thibsy