UI: add Input\Container::withInput for awesome flexibility #8746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klees
force-pushed
the
11/UI/withInputData
branch
from
bd1ec69 to
259588a
Compare
thibsy
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Hi @klees,
Thx a lot for your contribution to the UI components!
Introducing a flexible way on our input containers to provide input data seems plausible and should interact seamlessly with our existing logic.
We have one minor change, which should not stop this from going to JF or postpone your implementation. However, please implement the following changes:
-
withInputData(): please rename this method towithInput()so it is similar to theInput::withInput()method.withInputData()may be more appropriate, but since it essentially does the same thing, we should try to be consistent here.
klees
force-pushed
the
11/UI/withInputData
branch
from
259588a to
9b87723
Compare
|
@thibsy/@Amstutz: Done. I also added the implementation now. |
klees
changed the title
klees
force-pushed
the
11/UI/withInputData
branch
from
9b87723 to
9838405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
this is something that came up when @jeph864 and I were discussing Activitities and webservices.
The current plan is to use the inputs from the UI framework as a description for the input to Activities. @jeph864 is looking how these Activities can be published via a json-via-http API and, for this purpose, will need a way to provide values to the input. At first we thought that we might want to teach the UI framework how to deal with JSON input in a
ServerRequestInterface, but then we found this solution to be more flexible and also simpler. This could open up the inputs from the UI framework to even more forms of user interface, such as the CLI.The implementation should be quite obvious, but I'll wait until I have approval from @Amstutz and @thibsy here.
What do you think?
Kind regards!