KS: 41633: Video Player not working

[alex40724]

See https://mantis.ilias.de/view.php?id=41633

Major changes:

• No mediaelment.js lib is used.
• Native video/audio tag and youtube/vimeo iframes are being used.
• Consumers need to provide correct embed src for vimeo and youtube.

I added this to the Jour Fix agenda, since this fix includes major changes that affect styling, accessibility and consumer code.

[matthiaskunkel]

Jour Fixe, 11 NOV 2024: We discussed the PR and appreciate the change to the native video players of YouTube or Vimeo. A final decision about the PR can be made after the revision of the PR by the UI coordinators. In addition, our privacy experts will have a look at the suggestion to check if it makes privacy worse compared to the former implementation.

[alex40724]

The external js has been removed, since it is not needed here. Connection to youtube/vimeo is only setup, if the iframes are rendered like before.

[alex40724]

One explanation: The video tag uses a transparent 1pixel gif and a background image source to ensure the possibility to apply css rules to the background/poster. I did not find a better solution for this. Tests are fixed now.

[klees]

Hi @alex40724,

please rebase and ping me, I'll merge then.

Thanks!

[alex40724]

@klees Since there is no conflict, github offers already a "Rebase and Merge" in the "Squash and merge" dropdown.

[klees]

Hi @alex40724,

for me it looks like this:

Really strange... Does it have a green button for you?

Kind regards!

[klees]

Ok, I think I might have found the issue. This PR seems to rollback some change in the video player.

@Amstutz / @thibsy / @nhaagen / @alex40724 I would suggest the following course of action: I would merge @nhaagen|s PR first. This should make @alex40724|s PR mergeable again and also documents the mildly crude way our development has taken here.