Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.html : Added my name, Snehal Gupta #14

Merged
merged 1 commit into from
Apr 3, 2017

Conversation

snehalgupta
Copy link
Contributor

@snehalgupta snehalgupta commented Apr 3, 2017

My name was added in the HTML file as a part of Arche Contributors
Closes #15

My name was added in the HTML file as a part of Arche Contributors
Closes IIIT-Delhi#8
@madhur-tandon
Copy link
Member

Hey, It seems like you did not create an issue for yourself as written in the guide and also, You referenced issue #8 while submitting a PR.

To fix this, Kindly do the following :)

  1. Create an issue with title as snehalgupta as mentioned in the guide.
  2. The PR looks fine, however the commit message needs to be changed to refer the new issue,
    To do this, simply type git commit --amend, after your editor pops up, please refer to the new issue you just created. After this is done, use git push -f origin snehalgupta to force push your changes :)

@snehalgupta
Copy link
Contributor Author

Okay done :)

@madhur-tandon madhur-tandon merged commit cb081c5 into IIIT-Delhi:master Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants