Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow slash as first character in CordCellRef #560

Closed
wants to merge 2 commits into from

Conversation

alexanderpann
Copy link
Member

@alexanderpann alexanderpann commented Apr 7, 2022

The slash character in the expression doesn't interfere with the optional cell anymore.
Fixes #559

@alexanderpann alexanderpann changed the title Don't allow slash as first character in CorrdCellRef Don't allow slash as first character in CordCellRef Apr 7, 2022
@sergej-koscejev
Copy link
Member

This does not fix #559. The problem is if you go to http://127.0.0.1:63320/node?ref=r%3Ac26f3707-1ecb-413e-ba84-cd641318e760%28playground.sheets%29%2F3922243018846595131 and try to type this same assertion from scratch on another line - it won't work.

@alexanderpann
Copy link
Member Author

You are both right. At the time, it seemed to work, but with the current master it certainly doesn't. The problem is related to the optional cell, but I couldn't find a nice solution where I don't introduce an unnecessary space in the editor.
example: $ AnotherExampleSheet/A0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spreadsheets: adding sheet with '/' does not work
2 participants