Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable untyped columns in DataTable #1183

Merged
merged 3 commits into from
Dec 16, 2024
Merged

re-enable untyped columns in DataTable #1183

merged 3 commits into from
Dec 16, 2024

Conversation

enikao
Copy link
Collaborator

@enikao enikao commented Dec 12, 2024

re-enable untyped columns in DataTable

Used to work before #943

@enikao enikao enabled auto-merge December 12, 2024 15:00
@enikao
Copy link
Collaborator Author

enikao commented Dec 16, 2024

@alexanderpann What do you think, can we merge that?

@enikao enikao merged commit db4c887 into maintenance/mps20232 Dec 16, 2024
1 check passed
alexanderpann
alexanderpann approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@alexanderpann alexanderpann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can also add me as a reviewer so that I get a notification the next time

@enikao enikao deleted the bugfix/re-enable-untyped-datatable-column branch December 16, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderpann alexanderpann alexanderpann approved these changes

@arimer arimer Awaiting requested review from arimer arimer is a code owner

@wsafonov wsafonov Awaiting requested review from wsafonov wsafonov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enikao @alexanderpann