Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added google test and moved tests. #577

Merged
merged 62 commits into from
Jul 31, 2024

Conversation

ChristianFeldmann
Copy link
Member

@ChristianFeldmann ChristianFeldmann commented Jul 7, 2024

  • Get googletest as a submodule and compile it with qmake.
  • Ported all current tests to Googletest.
  • Refactor EnumMapper to be constexpr

@ChristianFeldmann ChristianFeldmann marked this pull request as ready for review July 29, 2024 16:09
Copy link
Member Author

@ChristianFeldmann ChristianFeldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. To-do:

  • Rename EnumMapper getItems. Should be getValues.
  • Test running of YUView

@ChristianFeldmann ChristianFeldmann changed the title Added google test and moved a first test over (file name guessing test). Added google test and moved tests. Jul 31, 2024
@ChristianFeldmann
Copy link
Member Author

Check and check.

@ChristianFeldmann ChristianFeldmann merged commit 8e13a10 into develop Jul 31, 2024
9 checks passed
@ChristianFeldmann ChristianFeldmann deleted the feature/addGoogleTestAsSubmodule branch July 31, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant