Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: component base tidying #2555

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Nov 25, 2024

PR Checklist

  • PR title descriptive (can be used in release notes)

TODO

Description

Following on from #2531, some general housekeeping on components to remove manual specification of inherited base properties

Dev Notes

Any component that extends the baseComponent will already have access to properties like parent and row, so should not manually redefine unless overriding. Equally they shouldn't manually specify implements ITemplateRowProps as this is inherited from the base compoennt.

I'm guessing a lot of these duplicate specifications are due to copy-paste from older templates. There's still a handful of components that don't extend the base template definition (changed a couple as I noticed them), but I haven't extensively reviewed.

Review Notes

I'd expect any issue from removed code to be flagged by compiler, but adding screenshot comparison just to double-check

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

@github-actions github-actions bot added the scripts Work on backend scripts and devops label Nov 25, 2024
@github-actions github-actions bot added the maintenance Core updates, refactoring and code quality improvements label Nov 25, 2024
@chrismclarke chrismclarke added the test - visual Run visual regression tests label Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

Visual Test Summary
new : 0
different : 12
same : 303

Largest Differences
1 | 21.9% | comp_radio_group
2 | 2.1 % | example_lang_template_pop_2
3 | 0.4 % | user_actions
4 | 0.3 % | debug_data_items_condition
5 | 0.2 % | debug_advanced_dashed_box_1
6 | 0.2 % | example_calc_date
7 | 0.1 % | debug_set_field_2
8 | 0.1 % | example_calc
9 | 0.1 % | example_lang_template_pop_1
10 | 0.1 % | example_parent_point_box_info

Download Link
https://nightly.link/IDEMSInternational/parenting-app-ui/actions/runs/12018554864

Run Details
https://github.com/IDEMSInternational/parenting-app-ui/actions/runs/12018554864

@chrismclarke
Copy link
Member Author

Checked comp_radio_group and looks like a false-positive (can't see any noticeable difference when swapping branches locally). The example_template_popup_2 has a lottie animation which causes the diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Core updates, refactoring and code quality improvements scripts Work on backend scripts and devops test - visual Run visual regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants