-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: component base tidying #2555
base: master
Are you sure you want to change the base?
Conversation
Review: pr 2351 proposed changes
Visual Test Summary Largest Differences Download Link Run Details |
Checked |
PR Checklist
TODO
Description
Following on from #2531, some general housekeeping on components to remove manual specification of inherited base properties
Dev Notes
Any component that extends the
baseComponent
will already have access to properties like parent and row, so should not manually redefine unless overriding. Equally they shouldn't manually specifyimplements ITemplateRowProps
as this is inherited from the base compoennt.I'm guessing a lot of these duplicate specifications are due to copy-paste from older templates. There's still a handful of components that don't extend the base template definition (changed a couple as I noticed them), but I haven't extensively reviewed.
Review Notes
I'd expect any issue from removed code to be flagged by compiler, but adding screenshot comparison just to double-check
Git Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes