Chore: update action artifact versions #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
github-actions
bot
removed
the
documentation
|
Visit the preview URL for this PR (updated for commit e355a65): https://plh-teens-app1--pr2410-chore-action-artifac-itc6nwx0.web.app (expires Wed, 25 Sep 2024 22:58:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e4c0bab6b08dd290fbf002fd6e07987fa4b5fce1 |
chrismclarke
changed the title
ChrisMarsh82
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
Review Notes
Testing done by triggering actions from Temp content repo PR IDEMSInternational/app-debug-content#82
Before
Example Failed Action when targeting
masterbranch from debug deployment content repoAfter
Example Passing Action when targeting this branch
Dev Notes
There is some confusion as various actions use both
upload-artifactandupload-pages-artifact. Theupload-pages-artifactis simply a lightweight wrapper aroundupload-artifact(some minor modifications to folder structures, if I remember I think the upload-artifact nests everything in a subfolder while the upload-pages-artifact doesn't have nesting... although may have changed with recent versions) - although the upload-pagesv3action targets the upload-artifactv4branch (and so should be used withdownload-artifactv4 alsoIt might be possible to completely remove the
upload-pages-artifactcalls (to be investigated)Git Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes