Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: set default node version 20 #2385

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

chrismclarke
Copy link
Member

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

Following comments in #2376, update documentation and CI to default to using node v20.

As per https://nodejs.org/en/about/previous-releases, this version should be supported until April 2026 (although we may decide to start testing node 22 support from October)
image

Review Notes

The only scope for knock-ons would be within github actions, which are hard to test in advance. I'll trigger what actions I can from this branch, assuming that node is mostly just used for app build and screenshot compare (not play/ios signing deploy) so should consider likely stable if passing here.

Dev Notes

I've pinned explicitly to 20.17.0 as the most recent v20 release. I've been running this version locally without issue so I'd hope everything just works as expected.

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

Copy link

github-actions bot commented Aug 29, 2024

Visit the preview URL for this PR (updated for commit 44a41ea):

https://plh-teens-app1--pr2385-chore-default-node-2-uhaklzqw.web.app

(expires Thu, 26 Sep 2024 18:33:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c0bab6b08dd290fbf002fd6e07987fa4b5fce1

Copy link

github-actions bot commented Aug 29, 2024

Visual Test Summary
new : 0
different : 5
same : 351

Largest Differences
1 | 0.4 % | user_actions
2 | 0.1 % | debug_set_field_2
3 | 0.1 % | example_calc_date
4 | 0.1 % | example_calc
5 | 0 % | feature_parent_point_box

Download Link
https://nightly.link/IDEMSInternational/parenting-app-ui/actions/runs/10836620504

Run Details
https://github.com/IDEMSInternational/parenting-app-ui/actions/runs/10836620504

Copy link
Collaborator

@jfmcquade jfmcquade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, happy to merge if the github actions all look good.

I've switched from node v18.19.1 to v20.17.0 in order to test this branch, I'll report any issues I come across.

When setting up @kwAsant's dev environment, we came across an error resembling the one documented here, The punycode module is deprecated. In my memory, we resolved this by changing node version from 20 to 18, however it may be that the original node version where the issue was observed was in fact 22.

As a test, I cloned a fresh version of the repo and ran yarn install, with node v20.17.0 active, and got no issues, so I think all should be good (me and Jody are both on similar Macs fwiw).

Screenshot 2024-09-12 at 14 40 02

@chrismclarke
Copy link
Member Author

Yeah I get the punycode deprecation warning on node 22, can see on the node docs it's now considered deprecated:
https://nodejs.org/api/punycode.html

Although a lot of our package use it still, so all the 3rd parties get updated I don't think there's much that can be done

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test - preview Create a preview deployment of the PR test - visual Run visual regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants