-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: set default node version 20 #2385
Conversation
Visit the preview URL for this PR (updated for commit 44a41ea): https://plh-teens-app1--pr2385-chore-default-node-2-uhaklzqw.web.app (expires Thu, 26 Sep 2024 18:33:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e4c0bab6b08dd290fbf002fd6e07987fa4b5fce1 |
Visual Test Summary Largest Differences Download Link Run Details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, happy to merge if the github actions all look good.
I've switched from node v18.19.1 to v20.17.0 in order to test this branch, I'll report any issues I come across.
When setting up @kwAsant's dev environment, we came across an error resembling the one documented here, The punycode module is deprecated
. In my memory, we resolved this by changing node version from 20 to 18, however it may be that the original node version where the issue was observed was in fact 22.
As a test, I cloned a fresh version of the repo and ran yarn install
, with node v20.17.0 active, and got no issues, so I think all should be good (me and Jody are both on similar Macs fwiw).
Yeah I get the punycode deprecation warning on node 22, can see on the node docs it's now considered deprecated: Although a lot of our package use it still, so all the 3rd parties get updated I don't think there's much that can be done |
PR Checklist
Description
Following comments in #2376, update documentation and CI to default to using node v20.
As per https://nodejs.org/en/about/previous-releases, this version should be supported until April 2026 (although we may decide to start testing node 22 support from October)
Review Notes
The only scope for knock-ons would be within github actions, which are hard to test in advance. I'll trigger what actions I can from this branch, assuming that node is mostly just used for app build and screenshot compare (not play/ios signing deploy) so should consider likely stable if passing here.
Dev Notes
I've pinned explicitly to
20.17.0
as the most recent v20 release. I've been running this version locally without issue so I'd hope everything just works as expected.Git Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes