Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: data generators #2379

Merged
merged 2 commits into from
Sep 10, 2024
Merged

docs: data generators #2379

merged 2 commits into from
Sep 10, 2024

Conversation

chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Aug 29, 2024

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

  • Add documentation for data generators
  • Include special use case for issue recently discovered

Review Notes

I haven't linked to example sheets as I couldn't remember if we have good examples of data generators or not

Author Notes

I don't think the example outlined has ever been coded into a debug/example template for the debug repo - might be useful to do so for easier reference

Dev Notes

The Special Case issue mentioned in the docs is particular to the case where the generator is used to create data_pipes, which in turn need to refer to @row variables. The @row is processed one level too soon (i.e. processed by the generator and not left for processing within the data_pipe).

I couldn't wrap my head around how best to go about making sure something like that doesn't happen in the code (felt like a lot of potential for knock-ons if too heavy-handed and hacky if writing single-level exceptions), so for now hopefully just having documented is sufficient (assume a pretty rare case)

Git Issues

Closes #

Screenshots/Videos

Rendered Doc

127 0 0 1_8000_authors_advanced_data-generators_ (1)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 29, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Aug 29, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Aug 29, 2024
Copy link
Collaborator

@esmeetewinkel esmeetewinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this. I don't think I'd come across this case before, or if I did I didn't get to the bottom of it!

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Sep 10, 2024
@chrismclarke chrismclarke merged commit 7367f4c into master Sep 10, 2024
7 checks passed
@chrismclarke chrismclarke deleted the docs/data-generators branch September 10, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants