Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates to README and Deployments section #2372

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

jfmcquade
Copy link
Collaborator

@jfmcquade jfmcquade commented Aug 21, 2024

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

  • Updates README to specify recommended Node version, and for general clarity
  • Mirrors changes to README in external docs intro page, index.md (this had become out of sync with the README)
  • Restructures "Deployments" docs page to put "Import Existing" section at the top
    • This is by far the most commonly relevant section for readers of the docs

Git Issues

Closes #

Screenshots/Videos

Intro

Docs Intro

Deployments:

Screenshot 2024-08-21 at 15 21 05

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 21, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Aug 21, 2024
Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks for updating these. See one minor comment inline, but happy to merge either way


1. Download and install [Git](https://git-scm.com/downloads)
This will be used to download the repository

2. Download and install [Git LFS](https://git-lfs.github.com/)
This will be used to download any required binary assets, such as images or pdfs

3. Download and install [Node](https://nodejs.org/en/download/)
This is the programming lanugage required to run the project
3. Download and install [Node](https://nodejs.org/en/download/) (choose v18.20.4)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit(non-blocking): not sure how precise we want to be with node version. All our CI uses 18.x, I personally run 20.7.0 (due to known issues for our codebase on higher #2185), so I think could be fine to just suggest

choose v18 or v20

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh, @kwAsant had some general issues running v22, I'm tempted to specify v18 for now

@jfmcquade jfmcquade merged commit d0752db into master Aug 22, 2024
5 checks passed
@jfmcquade jfmcquade deleted the docs/update-readme branch August 22, 2024 16:29
@chrismclarke chrismclarke mentioned this pull request Aug 25, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants