Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/migration service #1814

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Feat/migration service #1814

wants to merge 4 commits into from

Conversation

chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Feb 28, 2023

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)

TODO

  • Realise already have lifecycleActions service so should refactor to base on that
  • Add author option and db bindings to define actions that should only ever process once and/or be linked to specific version updates
  • Add demo sheets
  • Update documentation

Breaking Changes

  • Adds MIGRATION_ACTIONS deployment config option. Any local deployments will need to be recompiled to use post merge
yarn scripts deployment set

Description

What this PR does

Discussion

  • Should these be defined better as lifecycle_actions or similar to allow registering actions more generally for startup (and give the option to repeat running)? If so might need to make small RFC or at least define the in-built triggers (e.g. app_start, app_minimize, app_resume, app_close, app_update etc.). Could also just be global actions or similar

Author Notes

See documentation example (screenshot below)

Review Notes

Set plh_debug config

yarn workflow deployment set plh_debug

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant