-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved detection & display of data types #6288
Improved detection & display of data types #6288
Conversation
merge from main
merge from main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work fine, so I approve.
I tried with data and should say I don't like the use of capital letters any more than I think they are frowned on by tidyverse? It isn't so bad for D, but having lots of F and O.F and C is a bit shouty?
It is a bit, but I think it adds clarity. It's probably more noticeable for existing users who are used to the lower case. Could we try it out up to the next release and if you're still not convinced we go back to some lower case? |
@rdstern Please could you test/approve again? thanks |
fixes #6266
@africanmathsinitiative/developers this is ready for review