Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved detection & display of data types #6288

Merged
merged 4 commits into from
Mar 18, 2021

Conversation

dannyparsons
Copy link
Contributor

fixes #6266

  • Symbols now in upper case
  • Dates group expanded to date and time related columns
  • Added (S) for structured (circular only for now)
  • Added (A) for application (not implemented yet)

@africanmathsinitiative/developers this is ready for review

rdstern
rdstern previously approved these changes Mar 17, 2021
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work fine, so I approve.
I tried with data and should say I don't like the use of capital letters any more than I think they are frowned on by tidyverse? It isn't so bad for D, but having lots of F and O.F and C is a bit shouty?

@dannyparsons
Copy link
Contributor Author

It is a bit, but I think it adds clarity. It's probably more noticeable for existing users who are used to the lower case.
We already use it for D and also we had to have L for logical because "l" wasn't clear. So if we want consistency capitals is the only way to go. But I'm not completely against mixing upper and lower.

Could we try it out up to the next release and if you're still not convinced we go back to some lower case?

instat/clsGridLink.vb Outdated Show resolved Hide resolved
@lloyddewit
Copy link
Contributor

@rdstern Please could you test/approve again? thanks

@maxwellfundi maxwellfundi merged commit 94903db into IDEMSInternational:master Mar 18, 2021
@dannyparsons dannyparsons deleted the data-types branch March 18, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display of data types in the R-Instat grid
5 participants